From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D353FC4332F for ; Tue, 2 Nov 2021 09:01:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCB2760F58 for ; Tue, 2 Nov 2021 09:01:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbhKBJD4 (ORCPT ); Tue, 2 Nov 2021 05:03:56 -0400 Received: from foss.arm.com ([217.140.110.172]:58656 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhKBJDy (ORCPT ); Tue, 2 Nov 2021 05:03:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C3BB113E; Tue, 2 Nov 2021 02:01:19 -0700 (PDT) Received: from bogus (unknown [10.57.46.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C8E33F5A1; Tue, 2 Nov 2021 02:01:17 -0700 (PDT) Date: Tue, 2 Nov 2021 09:01:15 +0000 From: Sudeep Holla To: Wan Jiabing Cc: Wolfram Sang , Zhiqi Song , Tian Tao , Florian Fainelli , linux-i2c@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, jiabing.wan@qq.com Subject: Re: [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR Message-ID: <20211102090115.svupxektn2vpa7id@bogus> References: <20211102021229.18501-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211102021229.18501-1-wanjiabing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wan, On Mon, Nov 01, 2021 at 10:12:27PM -0400, Wan Jiabing wrote: > Fix following coccicheck warning: > ./drivers/i2c/busses/i2c-xgene-slimpro.c:488:6-12: inconsistent IS_ERR > and PTR_ERR on line 490. There is another version @[1]. Thanks for the effort. Hi Wolfram, Can you pick [1] after -rc1 ? I see mailbox updates are in the mainline already. -- Regards, Sudeep [1] https://lore.kernel.org/kernel-janitors/20211101140235.777322-1-weiyongjun1@huawei.com/