From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6694DC433F5 for ; Tue, 2 Nov 2021 11:02:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5032F60EE9 for ; Tue, 2 Nov 2021 11:02:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbhKBLE7 (ORCPT ); Tue, 2 Nov 2021 07:04:59 -0400 Received: from first.geanix.com ([116.203.34.67]:37536 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbhKBLEu (ORCPT ); Tue, 2 Nov 2021 07:04:50 -0400 Received: from zen.. (unknown [185.17.218.86]) by first.geanix.com (Postfix) with ESMTPSA id D1CE3D746D; Tue, 2 Nov 2021 11:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1635850929; bh=WfKdVcgX6AGTMY936VHnBpAoH4wgP3qvp6CWej1BIvg=; h=From:To:Cc:Subject:Date; b=mEm9AL5pdSrJTTch7iJacDrm+YLTiO5K6iKxGxNaYm/vtvfmuvhx/PxGFfJ1g/DNK iIoeEWXLVQ9+tAch2MChSJDVclOYP1hHVg2vOgtgmBbVQv3wUT+jbKqW577B9Y89Nq Vj+dsDlwmBZj0XApksD4xjLIlEbTTmdNuHWKhcUqLo5nMvdnW5X1pN7LKlcKWJvJqt NGcaUa1wkfPS/JIuscoinUfpl3+jFQdxHYLsRdCy3ChaFfpIXcwU0McE7PR9qsogbQ S/8EqpJ+ag9gr4MTaaG9AFu1PxyHkQngqCSkfyHRi3E9DoHiCWb08FX5uaLz0LJZNn z9Ss4KNJirPGw== From: Sean Nyekjaer To: Boris Brezillon Cc: Sean Nyekjaer , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 0/4] mtd: core: protect access to mtd devices while in suspend Date: Tue, 2 Nov 2021 12:02:00 +0100 Message-Id: <20211102110204.3334609-1-sean@geanix.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes since v4: - removed protection around _panic_write() - removed all fixes tag, as a simpler solution is needed for backporting. Follow-up on discussion in: https://lkml.org/lkml/2021/10/4/41 https://lkml.org/lkml/2021/10/11/435 Changes since v3: - edited commit msg and author for mtdconcat patch Changes since v2: - added signoff's to patch from Boris - removed accidential line break - kept tests consistent: master->master.suspended == 0 -> !master->master.suspended - added comments to mtdconcat patch - moved mtdconcat before ('mtd: core: protect access to MTD devices while in suspend') Changes since v1: - removed __mtd_suspend/__mtd_resume functions as they are not used by mtdconcat anymore. - only master mtd_info is used for mtd_{start,end}_access(). Warn if we got mtd's. - added Boris patch for using uninitialized _suspend/_resume hooks when bbt scanning - mtdconcat uses device _suspend/_resume hooks - I don't really like the macro proposal from Boris mtd_no_suspend_void_call()/mtd_no_suspend_ret_call() I think they make the code complex to read and the macro's doesn't fit every where anyway... Changes since from rfc v1/v2: - added access protection for all device access hooks in mtd_info. - added Suggested-by to [1/3] patch. - removed refereces to commit ef347c0cfd61 ("mtd: rawnand: gpmi: Implement exec_op") from commit msg as commit 013e6292aaf5 ("mtd: rawnand: Simplify the locking") is to be blamed. - tested on a kernel with LOCKDEP enabled. Boris Brezillon (2): mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt mtd: mtdconcat: don't use mtd_{suspend,resume}() Sean Nyekjaer (2): mtd: core: protect access to MTD devices while in suspend mtd: rawnand: remove suspended check drivers/mtd/mtdconcat.c | 15 +++- drivers/mtd/mtdcore.c | 124 +++++++++++++++++++++++++++---- drivers/mtd/nand/raw/nand_base.c | 52 ++++--------- drivers/mtd/nand/raw/nand_bbt.c | 28 ++++++- include/linux/mtd/mtd.h | 81 ++++++++++++++++---- include/linux/mtd/rawnand.h | 5 +- 6 files changed, 230 insertions(+), 75 deletions(-) -- 2.33.0