Re: [PATCH 06/17] media: atomisp: pci: use IA_CSS_ERROR() for error messages in sh_css_mipi.c

From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tsuchiya Yuto <kitakar@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Patrik Gfeller <patrik.gfeller@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Yang Yingliang <yangyingliang@huawei.com>,
	Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Alan <alan@linux.intel.com>, Dinghao Liu <dinghao.liu@zju.edu.cn>,
	Deepak R Varma <drv@mailo.com>,
	Alex Dewar <alex.dewar90@gmail.com>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/17] media: atomisp: pci: use IA_CSS_ERROR() for error messages in sh_css_mipi.c
Date: Tue, 2 Nov 2021 14:35:40 +0300	[thread overview]
Message-ID: <20211102113540.GD2794@kadam> (raw)
In-Reply-To: <20211017161958.44351-7-kitakar@gmail.com>

On Mon, Oct 18, 2021 at 01:19:46AM +0900, Tsuchiya Yuto wrote:
>  .../staging/media/atomisp/pci/sh_css_mipi.c   | 32 ++++++++-----------
>  1 file changed, 13 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> index c1f2f6151c5f..de56a1da754d 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> @@ -434,9 +434,8 @@ allocate_mipi_frames(struct ia_css_pipe *pipe,
>  
>  	if ((!IS_ISP2401 && port >= N_CSI_PORTS) ||
>  	    (IS_ISP2401 && err)) {
> -		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
> -				    "allocate_mipi_frames(%p) exit: error: port is not correct (port=%d).\n",
> -				    pipe, port);
> +		IA_CSS_ERROR("allocate_mipi_frames(%p) exit: port is not correct (port=%d).",
> +			     pipe, port);

Not related to this patch but these printks should be using __func__
instead of hard coding it.

regards,
dan carpenter