* [PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe
@ 2021-11-03 1:48 He Ying
2021-11-09 2:07 ` He Ying
0 siblings, 1 reply; 2+ messages in thread
From: He Ying @ 2021-11-03 1:48 UTC (permalink / raw)
To: mpe, benh, paulus, maz; +Cc: linuxppc-dev, linux-kernel
Early exits from for_each_compatible_node() should decrease the
node reference count.
Signed-off-by: He Ying <heying24@huawei.com>
---
arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
index 15396333a90b..a4b020e4b6af 100644
--- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
+++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
@@ -214,6 +214,7 @@ void hlwd_pic_probe(void)
irq_set_chained_handler(cascade_virq,
hlwd_pic_irq_cascade);
hlwd_irq_host = host;
+ of_node_put(np);
break;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe
2021-11-03 1:48 [PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe He Ying
@ 2021-11-09 2:07 ` He Ying
0 siblings, 0 replies; 2+ messages in thread
From: He Ying @ 2021-11-09 2:07 UTC (permalink / raw)
To: mpe, benh, paulus, maz; +Cc: linuxppc-dev, linux-kernel
kindly ping...
在 2021/11/3 9:48, He Ying 写道:
> Early exits from for_each_compatible_node() should decrease the
> node reference count.
>
> Signed-off-by: He Ying <heying24@huawei.com>
> ---
> arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> index 15396333a90b..a4b020e4b6af 100644
> --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> @@ -214,6 +214,7 @@ void hlwd_pic_probe(void)
> irq_set_chained_handler(cascade_virq,
> hlwd_pic_irq_cascade);
> hlwd_irq_host = host;
> + of_node_put(np);
> break;
> }
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-09 2:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 1:48 [PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe He Ying
2021-11-09 2:07 ` He Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).