[PATCH] ACPI: EC: fix error "do not initialise statics to false"

[PATCH] ACPI: EC: fix error "do not initialise statics to false"

[wangzhitong]

this patch fixes below Errors reported by checkpatch
ERROR: do not initialise statics to false
+static bool ec_freeze_events __read_mostly = false;
ERROR: do not initialise statics to false
+static bool boot_ec_is_ecdt = false;

Signed-off-by: wangzhitong <wangzhitong@uniontech.com>
---
 drivers/acpi/ec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 04ce2b96c3da..1255649a4da9 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -133,7 +133,7 @@ static unsigned int ec_storm_threshold  __read_mostly = 8;
 module_param(ec_storm_threshold, uint, 0644);
 MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");
 
-static bool ec_freeze_events __read_mostly = false;
+static bool ec_freeze_events __read_mostly;
 module_param(ec_freeze_events, bool, 0644);
 MODULE_PARM_DESC(ec_freeze_events, "Disabling event handling during suspend/resume");
 
@@ -177,7 +177,7 @@ struct acpi_ec *first_ec;
 EXPORT_SYMBOL(first_ec);
 
 static struct acpi_ec *boot_ec;
-static bool boot_ec_is_ecdt = false;
+static bool boot_ec_is_ecdt;
 static struct workqueue_struct *ec_wq;
 static struct workqueue_struct *ec_query_wq;
 
-- 
2.20.1

Re: [PATCH] ACPI: EC: fix error "do not initialise statics to false"

[Rafael J. Wysocki]

On Wed, Nov 3, 2021 at 6:52 AM wangzhitong <wangzhitong@uniontech.com> wrote:
>
> this patch fixes below Errors reported by checkpatch
> ERROR: do not initialise statics to false
> +static bool ec_freeze_events __read_mostly = false;
> ERROR: do not initialise statics to false
> +static bool boot_ec_is_ecdt = false;
>
> Signed-off-by: wangzhitong <wangzhitong@uniontech.com>
> ---
>  drivers/acpi/ec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 04ce2b96c3da..1255649a4da9 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -133,7 +133,7 @@ static unsigned int ec_storm_threshold  __read_mostly = 8;
>  module_param(ec_storm_threshold, uint, 0644);
>  MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");
>
> -static bool ec_freeze_events __read_mostly = false;
> +static bool ec_freeze_events __read_mostly;
>  module_param(ec_freeze_events, bool, 0644);
>  MODULE_PARM_DESC(ec_freeze_events, "Disabling event handling during suspend/resume");
>
> @@ -177,7 +177,7 @@ struct acpi_ec *first_ec;
>  EXPORT_SYMBOL(first_ec);
>
>  static struct acpi_ec *boot_ec;
> -static bool boot_ec_is_ecdt = false;
> +static bool boot_ec_is_ecdt;
>  static struct workqueue_struct *ec_wq;
>  static struct workqueue_struct *ec_query_wq;
>
> --

Applied as 5.16-rc material with rewritten changelog and subject, thanks!

Re: [PATCH] ACPI: EC: fix error "do not initialise statics to false"

[Rafael J. Wysocki]

On Thu, Nov 4, 2021 at 3:33 AM 王志桐 <wangzhitong@uniontech.com> wrote:
>
> hi  Rafael J
>
>   Thank you for your reply， Forgive me for my limited level 。
>   I do't understand your means:
> "Applied as 5.16-rc material with rewritten changelog and subject, thanks!"
> Please help me ， Please help guide ， How do I need to modify my patch.

You don't need to change it, I've changed it myself.

Basically, I've retained the code changes, but I've modified the patch
subject and description.