From: davidcomponentone@gmail.com
To: mchehab@kernel.org
Cc: hverkuil-cisco@xs4all.nl, arnd@arndb.de,
laurent.pinchart@ideasonboard.com, Julia.Lawall@inria.fr,
yang.guang5@zte.com.cn, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] media: use swap() to make code cleaner
Date: Wed, 3 Nov 2021 16:33:37 +0800 [thread overview]
Message-ID: <20211103083337.387083-1-yang.guang5@zte.com.cn> (raw)
From: Yang Guang <yang.guang5@zte.com.cn>
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
---
drivers/media/pci/saa7134/saa7134-video.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c
index 374c8e1087de..6f4132058c35 100644
--- a/drivers/media/pci/saa7134/saa7134-video.c
+++ b/drivers/media/pci/saa7134/saa7134-video.c
@@ -823,7 +823,7 @@ static int buffer_activate(struct saa7134_dev *dev,
{
struct saa7134_dmaqueue *dmaq = buf->vb2.vb2_buf.vb2_queue->drv_priv;
unsigned long base,control,bpl;
- unsigned long bpl_uv,lines_uv,base2,base3,tmp; /* planar */
+ unsigned long bpl_uv, lines_uv, base2, base3; /* planar */
video_dbg("buffer_activate buf=%p\n", buf);
buf->top_seen = 0;
@@ -869,9 +869,7 @@ static int buffer_activate(struct saa7134_dev *dev,
base2 = base + bpl * dev->height;
base3 = base2 + bpl_uv * lines_uv;
if (dev->fmt->uvswap) {
- tmp = base2;
- base2 = base3;
- base3 = tmp;
+ swap(base2, base3);
}
video_dbg("uv: bpl=%ld lines=%ld base2/3=%ld/%ld\n",
bpl_uv,lines_uv,base2,base3);
--
2.30.2
next reply other threads:[~2021-11-03 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 8:33 davidcomponentone [this message]
2021-11-03 15:14 ` [PATCH] media: use swap() to make code cleaner Kieran Bingham
2021-11-04 0:26 ` David Yang
2021-11-04 10:43 ` Andy Shevchenko
2021-11-08 9:16 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103083337.387083-1-yang.guang5@zte.com.cn \
--to=davidcomponentone@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=arnd@arndb.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=yang.guang5@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).