From: Dan Carpenter <dan.carpenter@oracle.com>
To: Praveen Kumar <kpraveen.lkml@gmail.com>
Cc: Kushal Kothari <kushalkothari285@gmail.com>,
gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, fmdefrancesco@gmail.com,
marcocesati@gmail.com, straube.linux@gmail.com,
philippesdixon@gmail.com, manuelpalenzuelamerino@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
mike.rapoport@gmail.com, kushalkotharitest@googlegroups.com,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8723bs: core: Remove true and false comparison
Date: Wed, 3 Nov 2021 14:52:47 +0300 [thread overview]
Message-ID: <20211103115247.GR2794@kadam> (raw)
In-Reply-To: <32059290-6c59-1cee-5edc-563fe5c2f18b@gmail.com>
On Fri, Oct 22, 2021 at 08:14:29AM +0530, Praveen Kumar wrote:
> On 22-10-2021 01:27, Kushal Kothari wrote:
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > index 2624e994513f..0be3a8dbeec8 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > @@ -371,7 +371,7 @@ void rtw_free_cmd_obj(struct cmd_obj *pcmd)
> > void rtw_stop_cmd_thread(struct adapter *adapter)
> > {
> > if (adapter->cmdThread &&
> > - atomic_read(&(adapter->cmdpriv.cmdthd_running)) == true &&
> > + atomic_read(&adapter->cmdpriv.cmdthd_running) &&
>
> Lets keep it "atomic_read(&(adapter->cmdpriv.cmdthd_running))"
> and remove the parentheses in next patch.
>
There is a certain amount of flexibility in fixing style errors which
occur on a line that you are already modifying. But your advice is good
because 1) Then the inclination is to say "please fix the alignment as
well". 2) There is already a [PATCH 2/4] which removes these extra
parentheses so it makes more sense to do it there. 3) This patchset
will need to be redone anyway because of the white space error in
[PATCH 4/4].
So, you are right, and especially in this case you're right. But there
are always going to be minor issues with a patch and some of them we can
let slide.
I have occasionally waited for Greg to apply a patch and then sent an
email, "Greg has already applied your patch but next time do it like
this." :P
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-03 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 19:57 [PATCH 0/4] staging: rtl8723bs: core: Cleanup patchset for style issues in rtw_cmd.c Kushal Kothari
2021-10-21 19:57 ` [PATCH 1/4] staging: rtl8723bs: core: Remove true and false comparison Kushal Kothari
2021-10-22 2:44 ` [Outreachy kernel] " Praveen Kumar
2021-11-03 11:52 ` Dan Carpenter [this message]
2021-10-21 19:57 ` [PATCH 2/4] staging: rtl8723bs: core: Remove unnecessary parentheses Kushal Kothari
2021-10-21 19:57 ` [PATCH 3/4] staging: rtl8723bs: core: Remove unnecessary space after a cast Kushal Kothari
2021-10-22 2:48 ` [Outreachy kernel] " Praveen Kumar
2021-10-21 19:57 ` [PATCH 4/4] staging: rtl8723bs: core: Remove unnecessary blank lines Kushal Kothari
2021-10-22 6:03 ` Greg KH
2021-10-22 2:45 ` [Outreachy kernel] [PATCH 0/4] staging: rtl8723bs: core: Cleanup patchset for style issues in rtw_cmd.c Praveen Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103115247.GR2794@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kpraveen.lkml@gmail.com \
--cc=kushalkothari285@gmail.com \
--cc=kushalkotharitest@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manuelpalenzuelamerino@gmail.com \
--cc=marcocesati@gmail.com \
--cc=mike.rapoport@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=philippesdixon@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).