From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1EF9C433EF for ; Fri, 5 Nov 2021 13:34:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B32ED61101 for ; Fri, 5 Nov 2021 13:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231517AbhKENgv (ORCPT ); Fri, 5 Nov 2021 09:36:51 -0400 Received: from netrider.rowland.org ([192.131.102.5]:52751 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S229924AbhKENgu (ORCPT ); Fri, 5 Nov 2021 09:36:50 -0400 Received: (qmail 1591263 invoked by uid 1000); 5 Nov 2021 09:34:10 -0400 Date: Fri, 5 Nov 2021 09:34:10 -0400 From: Alan Stern To: Greg KH Cc: Haimin Zhang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Haimin Zhang , TCS Robot Subject: Re: [PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with temp Message-ID: <20211105133410.GB1590803@rowland.harvard.edu> References: <20211105083357.29715-1-tcs_kernel@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 05, 2021 at 09:52:13AM +0100, Greg KH wrote: > On Fri, Nov 05, 2021 at 04:33:57PM +0800, Haimin Zhang wrote: > > In function `ehci_brcm_hub_control`, like following code, > > it filters out the case where the upper byte of wIndex is nonzero, > > so it need be replaced with temp. > > I do not understand this text, can you try to reword it? > > And you have trailing whitespace. > > And why use `? > > > ``` > > What is this for? Changelog comments are not in markdown format. > > > if ((typeReq == GetPortStatus) && > > (wIndex && wIndex <= ports) && // need to be replaced > > What does this comment mean? > > > ehci->reset_done[wIndex-1] && > > time_after_eq(jiffies, ehci->reset_done[wIndex-1]) && > > (ehci_readl(ehci, status_reg) & PORT_RESUME)) { > > ``` > > > > Signed-off-by: Haimin Zhang > > Reported-by: TCS Robot > > Again, lines need to be in different order, and your from: line is not > correct. > > Also, you need an individual email address, not a group email alias for > your contributions. We work with individuals, not groups. > > > > > --- > > drivers/usb/host/ehci-brcm.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c > > index a1e3290e5459..efcfca162126 100644 > > --- a/drivers/usb/host/ehci-brcm.c > > +++ b/drivers/usb/host/ehci-brcm.c > > @@ -73,9 +73,9 @@ static int ehci_brcm_hub_control( > > * of RESUME > > */ > > if ((typeReq == GetPortStatus) && > > - (wIndex && wIndex <= ports) && > > - ehci->reset_done[wIndex-1] && > > - time_after_eq(jiffies, ehci->reset_done[wIndex-1]) && > > + (temp < ports) && > > Where did temp come from? Also, as long as this piece of code is being changed, it would be a good idea to get rid of all the unnecessary parentheses. Alan Stern