Re: [PATCH v2][next] platform/x86: thinkpad_acpi: Convert platform driver to use dev_groups

From: kernel test robot <lkp@intel.com>
To: Len Baker <len.baker@gmx.com>,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <markgross@kernel.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Len Baker <len.baker@gmx.com>,
	ibm-acpi-devel@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2][next] platform/x86: thinkpad_acpi: Convert platform driver to use dev_groups
Date: Sat, 6 Nov 2021 19:56:03 +0800	[thread overview]
Message-ID: <202111061924.jlVmkEiQ-lkp@intel.com> (raw)
In-Reply-To: <20211023154036.6800-1-len.baker@gmx.com>

[-- Attachment #1: Type: text/plain, Size: 2188 bytes --]

Hi Len,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20211022]
[cannot apply to linus/master v5.15-rc6 v5.15-rc5 v5.15-rc4 v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Len-Baker/platform-x86-thinkpad_acpi-Convert-platform-driver-to-use-dev_groups/20211024-104449
base:   DEBUG invalid remote for branch next-20211022 cf6c9d12750cf6f3f6aeffcd0bdb36b1ac993f44
config: x86_64-randconfig-a013-20211028 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5db7568a6a1fcb408eb8988abdaff2a225a8eb72)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a4cfdbae28f3e975f08c0260ee0282cfa69269a4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Len-Baker/platform-x86-thinkpad_acpi-Convert-platform-driver-to-use-dev_groups/20211024-104449
        git checkout a4cfdbae28f3e975f08c0260ee0282cfa69269a4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/thinkpad_acpi.c:5581:37: warning: unused variable 'cmos_attr_group' [-Wunused-const-variable]
   static const struct attribute_group cmos_attr_group = {
                                       ^
   1 warning generated.

vim +/cmos_attr_group +5581 drivers/platform/x86/thinkpad_acpi.c

  5580	
> 5581	static const struct attribute_group cmos_attr_group = {
  5582		.is_visible = cmos_attr_is_visible,
  5583		.attrs = cmos_attributes,
  5584	};
  5585	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35044 bytes --]