From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 05/12] rtc: ab-eoz9: support UIE when available
Date: Sun, 7 Nov 2021 23:54:50 +0100 [thread overview]
Message-ID: <20211107225458.111068-5-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20211107225458.111068-1-alexandre.belloni@bootlin.com>
The RTC actually supports UIE when an interrupt is available.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-ab-eoz9.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-ab-eoz9.c b/drivers/rtc/rtc-ab-eoz9.c
index 50ead6fce880..e188ab517f1e 100644
--- a/drivers/rtc/rtc-ab-eoz9.c
+++ b/drivers/rtc/rtc-ab-eoz9.c
@@ -534,7 +534,6 @@ static int abeoz9_probe(struct i2c_client *client,
data->rtc->ops = &rtc_ops;
data->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
data->rtc->range_max = RTC_TIMESTAMP_END_2099;
- clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, data->rtc->features);
clear_bit(RTC_FEATURE_ALARM, data->rtc->features);
if (client->irq > 0) {
@@ -546,6 +545,8 @@ static int abeoz9_probe(struct i2c_client *client,
dev_err(dev, "failed to request alarm irq\n");
return ret;
}
+ } else {
+ clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, data->rtc->features);
}
if (client->irq > 0 || device_property_read_bool(dev, "wakeup-source")) {
--
2.31.1
next prev parent reply other threads:[~2021-11-07 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 22:54 [PATCH 01/12] rtc: handle alarms with a minute resolution Alexandre Belloni
2021-11-07 22:54 ` [PATCH 02/12] rtc: s35390a: let the core handle the alarm resolution Alexandre Belloni
2021-11-07 22:54 ` [PATCH 03/12] rtc: rv3032: " Alexandre Belloni
2021-11-07 22:54 ` [PATCH 04/12] rtc: ab-eoz9: use RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2021-11-07 22:54 ` Alexandre Belloni [this message]
2021-11-07 22:54 ` [PATCH 06/12] rtc: ab8500: let the core handle the alarm resolution Alexandre Belloni
2021-11-09 11:47 ` Linus Walleij
2021-11-07 22:54 ` [PATCH 07/12] rtc: rx8025: switch to devm_rtc_allocate_device Alexandre Belloni
2021-11-07 22:54 ` [PATCH 08/12] rtc: rx8025: let the core handle the alarm resolution Alexandre Belloni
2021-11-07 22:54 ` [PATCH 09/12] rtc: rx8025: set range Alexandre Belloni
2021-11-07 22:54 ` [PATCH 10/12] rtc: rx8025: clear RTC_FEATURE_ALARM when alarm are not supported Alexandre Belloni
2021-11-07 22:54 ` [PATCH 11/12] rtc: rx8025: use rtc_add_group Alexandre Belloni
2021-11-07 22:54 ` [PATCH 12/12] rtc: rx8025: use .set_offset/.read_offset Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211107225458.111068-5-alexandre.belloni@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).