linux-next: build warning after merge of the scsi-mkp tree

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (htmldocs)
produced this warning:

drivers/scsi/scsi_scan.c:129: warning: Function parameter or member 'dev' not described in 'scsi_enable_async_suspend'

Introduced by commit

  a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for async power management")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

Hi all,

On Tue, 19 Oct 2021 07:41:19 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/scsi/scsi_scan.c:129: warning: Function parameter or member 'dev' not described in 'scsi_enable_async_suspend'
> 
> Introduced by commit
> 
>   a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for async power management")

That commit is now in Linus' tree.

BTW, James, I tried to use your HansenPartnership.com email address, but
the DNS is giving SERVER FAIL errors for it ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi-mkp tree

[James Bottomley]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

On Mon, 2021-11-08 at 11:06 +1100, Stephen Rothwell wrote:
[...]
> BTW, James, I tried to use your HansenPartnership.com email address,
> but the DNS is giving SERVER FAIL errors for it ...

Should be fixed now.  An update in debian testing changed the way
dnssec works with bind9 and effectively caused a roll of my zone
signing key (or more accurately moved me from a separated ZSK KSK pair
to a combined key).  Anyway, since there was no DS record for the new
key the whole domain broke.  I've now fixed the delegation and it's
working again.

James



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2xxx_process_purls_pkt':
drivers/scsi/qla2xxx/qla_nvme.c:1183:20: warning: unused variable 'fcport' [-Wunused-variable]
 1183 |         fc_port_t *fcport = uctx->fcport;
      |                    ^~~~~~

Introduced by commit

  27177862de96 ("scsi: qla2xxx: Fix nvme_fc_rcv_ls_req() undefined error")

# CONFIG_NVME_FC is not set
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi-mkp tree

[Martin K. Petersen]

Stephen,

> After merging the scsi-mkp tree, today's linux-next build (arm64
> defconfig) produced this warning:
>
> drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
> drivers/ufs/host/ufs-qcom.c:1652:31: warning: unused variable 'host' [-Wunused-variable]
>  1652 |         struct ufs_qcom_host *host = ufshcd_get_variant(hba);
>       |                               ^~~~
>
> Introduced by commit
>
>   8f2b78652d05 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")

Now fixed up, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (arm64
defconfig) produced this warning:

drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: warning: unused variable 'host' [-Wunused-variable]
 1652 |         struct ufs_qcom_host *host = ufshcd_get_variant(hba);
      |                               ^~~~

Introduced by commit

  8f2b78652d05 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi-mkp tree

[Damien Le Moal]

On 5/23/23 12:38, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'
> 
> Introduced by commit
> 
>   df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
> 

Martin,

To make things simpler, I posted a small patch to fix this. Please feel free to
fold it in df60f9c64576. Thanks !

-- 
Damien Le Moal
Western Digital Research

Re: linux-next: build warning after merge of the scsi-mkp tree

[Damien Le Moal]

On 5/23/23 12:38, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'
> 
> Introduced by commit
> 
>   df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
> 

Martin,

This is missing:

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 69fc0d2c2123..c676b1e9b6c9 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct
ata_queued_cmd *qc,
 /**
  *     ata_mselect_control - Simulate MODE SELECT for control page
  *     @qc: Storage for translated ATA taskfile
+ *     @spg: sub-page of the control page
  *     @buf: input buffer
  *     @len: number of valid bytes in the input buffer
  *     @fp: out parameter for the failed field on error

Do you want me to send a fix patch or can you fold this in ?

-- 
Damien Le Moal
Western Digital Research

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (htmldocs)
produced this warning:

drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'

Introduced by commit

  df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi-mkp tree

[Brian King]

On 3/5/20 10:52 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 2 Mar 2020 08:36:20 -0600 Brian King <brking@linux.vnet.ibm.com> wrote:
>>
>> On 3/1/20 8:35 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the scsi-mkp tree, today's linux-next build (powerpc
>>> ppc64_defconfig) produced this warning:
>>>
>>> In file included from include/uapi/linux/posix_types.h:5,
>>>                  from include/uapi/linux/types.h:14,
>>>                  from include/linux/types.h:6,
>>>                  from include/linux/list.h:5,
>>>                  from include/linux/module.h:12,
>>>                  from drivers/scsi/ibmvscsi/ibmvfc.c:10:
>>> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
>>> include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
>>>     8 | #define NULL ((void *)0)
>>>       |              ^
>>> drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
>>>  3644 |   return NULL;
>>>       |          ^~~~
>>> drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
>>>  3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
>>>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Introduced by commit
>>>
>>>   54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")
>>
>> Thanks. I'll send the one line fix.
> 
> I am still getting this warning, but it is now after the merge of the
> scsi tree.
> 

I sent the fix to the list, waiting for it to get pulled in:

https://marc.info/?l=linux-scsi&m=158315998321290&w=2


-- 
Brian King
Power Linux I/O
IBM Linux Technology Center

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

Hi all,

On Mon, 2 Mar 2020 08:36:20 -0600 Brian King <brking@linux.vnet.ibm.com> wrote:
>
> On 3/1/20 8:35 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the scsi-mkp tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > In file included from include/uapi/linux/posix_types.h:5,
> >                  from include/uapi/linux/types.h:14,
> >                  from include/linux/types.h:6,
> >                  from include/linux/list.h:5,
> >                  from include/linux/module.h:12,
> >                  from drivers/scsi/ibmvscsi/ibmvfc.c:10:
> > drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
> > include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
> >     8 | #define NULL ((void *)0)
> >       |              ^
> > drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
> >  3644 |   return NULL;
> >       |          ^~~~
> > drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
> >  3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
> >       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> >   54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")
> 
> Thanks. I'll send the one line fix.

I am still getting this warning, but it is now after the merge of the
scsi tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi-mkp tree

[Brian King]

On 3/1/20 8:35 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> In file included from include/uapi/linux/posix_types.h:5,
>                  from include/uapi/linux/types.h:14,
>                  from include/linux/types.h:6,
>                  from include/linux/list.h:5,
>                  from include/linux/module.h:12,
>                  from drivers/scsi/ibmvscsi/ibmvfc.c:10:
> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
> include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
>     8 | #define NULL ((void *)0)
>       |              ^
> drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
>  3644 |   return NULL;
>       |          ^~~~
> drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
>  3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")
> 

Thanks. I'll send the one line fix.

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from include/uapi/linux/posix_types.h:5,
                 from include/uapi/linux/types.h:14,
                 from include/linux/types.h:6,
                 from include/linux/list.h:5,
                 from include/linux/module.h:12,
                 from drivers/scsi/ibmvscsi/ibmvfc.c:10:
drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
    8 | #define NULL ((void *)0)
      |              ^
drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
 3644 |   return NULL;
      |          ^~~~
drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
 3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/smartpqi/smartpqi_init.c: In function 'pqi_build_raid_path_request':
drivers/scsi/smartpqi/smartpqi_init.c:478:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
   cdb_length = 0;
   ~~~~~~~~~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:479:2: note: here
  case BMIC_IDENTIFY_CONTROLLER:
  ^~~~
drivers/scsi/smartpqi/smartpqi_init.c:487:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
   cdb_length = 0;
   ~~~~~~~~~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:488:2: note: here
  case BMIC_WRITE_HOST_WELLNESS:
  ^~~~

Introduced by commit

  171c28653a2d ("scsi: smartpqi: turn off lun data caching for ptraid")

This due to my use of -Wimplicit-fallthrough for Kees Cook.  This is
new code.  The warning can be suppressed by adding a comment like

  /* fall through */

just above the following "case" or "default" to indicate that the
fallthrough is intended.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

./usr/include/scsi/scsi_bsg_ufs.h:45: found __[us]{8,16,32,64} type without #include <linux/types.h>

Introduced by commits

  a851b2bd3632 ("scsi: uapi: ufs: Make utp_upiu_req visible to user space")
  e77044c5a842 ("scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi-mkp tree

[Hannes Reinecke]

On 07/12/2018 06:30 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the scsi-mkp tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> In file included from include/linux/spinlock_types.h:18:0,
>>                  from include/linux/spinlock.h:82,
>>                  from drivers/scsi/libfc/fc_rport.c:61:
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
>> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
>>                                              ^
>> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>>   struct fc_rport_priv *rdata;
>>                         ^~~~~
>>
>> Introduced by commit
>>
>>   ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
>>
>> It is actually complaining about function fc_rport_recv_plogi_req()
>> (presumably it is being inlined) and this looks like an actual bug :-(
> 
> This warning now appears after the merge of the scsi tree.
> 
I have send a new round of patches to the scsi mailing list (cf
'libfc/fcoe: disc_mutex fixes') which address this issue.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

Hi all,

On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/linux/spinlock_types.h:18:0,
>                  from include/linux/spinlock.h:82,
>                  from drivers/scsi/libfc/fc_rport.c:61:
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in this function [-Wmaybe-uninitialized]
>  #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
>                                              ^
> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>   struct fc_rport_priv *rdata;
>                         ^~~~~
> 
> Introduced by commit
> 
>   ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
> 
> It is actually complaining about function fc_rport_recv_plogi_req()
> (presumably it is being inlined) and this looks like an actual bug :-(

This warning now appears after the merge of the scsi tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/spinlock_types.h:18:0,
                 from include/linux/spinlock.h:82,
                 from drivers/scsi/libfc/fc_rport.c:61:
drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
                                             ^
drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
  struct fc_rport_priv *rdata;
                        ^~~~~

Introduced by commit

  ee35624e1e4e ("scsi: libfc: Add lockdep annotations")

It is actually complaining about function fc_rport_recv_plogi_req()
(presumably it is being inlined) and this looks like an actual bug :-(



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi James,

On Tue, 26 Sep 2017 14:09:47 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/hisi_sas/hisi_sas_main.c: In function 'hisi_sas_controller_reset':
> drivers/scsi/hisi_sas/hisi_sas_main.c:1049:24: warning: unused variable 'sas_ha' [-Wunused-variable]
>   struct sas_ha_struct *sas_ha = &hisi_hba->sha;
>                         ^
> 
> Introduced by commit
> 
>   042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")

This warning now exists in the scsi tree.
-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hisi_sas/hisi_sas_main.c: In function 'hisi_sas_controller_reset':
drivers/scsi/hisi_sas/hisi_sas_main.c:1049:24: warning: unused variable 'sas_ha' [-Wunused-variable]
  struct sas_ha_struct *sas_ha = &hisi_hba->sha;
                        ^

Introduced by commit

  042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

[Just adding Dick and James to the cc list]

On Thu, 24 Aug 2017 15:57:56 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: warning: 'lpfc_nvmet_replenish_context' defined but not used [-Wunused-function]
>  lpfc_nvmet_replenish_context(struct lpfc_hba *phba,
>  ^
> 
> Introduced by commit
> 
>   9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: warning: 'lpfc_nvmet_replenish_context' defined but not used [-Wunused-function]
 lpfc_nvmet_replenish_context(struct lpfc_hba *phba,
 ^

Introduced by commit

  9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi-mkp tree

[Christoph Hellwig]

On Mon, Nov 14, 2016 at 04:16:24PM +1100, Stephen Rothwell wrote:
> Hi Martin,
> 
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/hpsa.c: In function 'hpsa_free_irqs':
> drivers/scsi/hpsa.c:8223:40: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    free_irq(pci_irq_vector(h->pdev, 0), &h->q[i]);

The i here shold be h->intr_mode, I'll send a fix in a bit.

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hpsa.c: In function 'hpsa_free_irqs':
drivers/scsi/hpsa.c:8223:40: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
   free_irq(pci_irq_vector(h->pdev, 0), &h->q[i]);
                                        ^

Introduced by commit

  bc2bb1543e62 ("scsi: hpsa: use pci_alloc_irq_vectors and automatic irq affinity")

-- 
Cheers,
Stephen Rothwell