From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37FDAC433FE for ; Tue, 9 Nov 2021 01:23:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21A0961359 for ; Tue, 9 Nov 2021 01:23:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241199AbhKIB0L (ORCPT ); Mon, 8 Nov 2021 20:26:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:44354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243075AbhKIBTM (ORCPT ); Mon, 8 Nov 2021 20:19:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 794F5619E9; Tue, 9 Nov 2021 01:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636420050; bh=T8kPapjxySRQi2XEtlStghEYlsOPqjHtXX/wn4lH+R0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pSb+tJaN4UK3++BFextOPU3MWdlk8ydSQkTkDO0r7NEAZ+xt4Ct9G1PHav7a5jUMr MsaqrPlsz31GlrzL1re2h8ZmPVoqHThEwSSR3Q6k1xom9GQ5aogzaHq0WoLwh6WKgh vudH70/uRr5UotRYucMIV33dEEr0oQvmn9MNBfXwertNPtfLJcNGS8I7GyGAqch++t 36bk832Uv/RhkyUto7cpEjHN8g+9KgMhRUARKgpEir7Qf+fciSPxg8WhsdcUtYmXBR iJC54GflsVCOq//zfNpZtgkqnxIuFWc1DawzUPqpQYQKVzPiU5iumq1ibkZyMvd1Xx 8r8S+RWulRNmg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Andr=C3=A9=20Almeida?= , Hans de Goede , Sebastian Reichel , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 23/39] ACPI: battery: Accept charges over the design capacity as full Date: Mon, 8 Nov 2021 20:06:33 -0500 Message-Id: <20211109010649.1191041-23-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109010649.1191041-1-sashal@kernel.org> References: <20211109010649.1191041-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: André Almeida [ Upstream commit 2835f327bd1240508db2c89fe94a056faa53c49a ] Some buggy firmware and/or brand new batteries can support a charge that's slightly over the reported design capacity. In such cases, the kernel will report to userspace that the charging state of the battery is "Unknown", when in reality the battery charge is "Full", at least from the design capacity point of view. Make the fallback condition accepts capacities over the designed capacity so userspace knows that is full. Signed-off-by: André Almeida Reviewed-by: Hans de Goede Reviewed-by: Sebastian Reichel Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 13e7b56e33aeb..30996effc491b 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -193,7 +193,7 @@ static int acpi_battery_is_charged(struct acpi_battery *battery) return 1; /* fallback to using design values for broken batteries */ - if (battery->design_capacity == battery->capacity_now) + if (battery->design_capacity <= battery->capacity_now) return 1; /* we don't do any sort of metric based on percentages */ -- 2.33.0