From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61FB7C43217 for ; Tue, 9 Nov 2021 01:19:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49B576120A for ; Tue, 9 Nov 2021 01:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239767AbhKIBVr (ORCPT ); Mon, 8 Nov 2021 20:21:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:44374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241154AbhKIBRS (ORCPT ); Mon, 8 Nov 2021 20:17:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F3D8961AFC; Tue, 9 Nov 2021 01:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636420022; bh=TslBu8qF10g5S/5SN3YoqK+yp13DOd4gZDb9BGhTW18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ixVtRE7Mp8TNzkPpDe3Yo1d1CwJrh4pn93ua2MwaOnUAl0ZeNaKuaXOAVwp8BAhOC RPaicERAAjSIUf0S1YxG4hFAqbpIsi3/eX237qViF4sECj/qHw2YyqOgApTTeuAsx5 j4tKSjZntU1lAuWfjSr3ZbGLFHID3GVh9+Ew1T5prp/5IHflhp/iAyu4IAEZpE5Ls/ 7xsKPcSHTcz+YZqvVmbULDu7x6iP7ncgCHdEPHacFSjz5jdH3YmTc+DSwoxI8RUQxt 9vPKLdfCh+TaCYp92WEri4CjEmunhZXgSlHOK0QBzRRLIpIwOgavv+ntCklqgEh3OQ U8Cv3IVCzEIjQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pawan Gupta , syzbot+3f91de0b813cc3d19a80@syzkaller.appspotmail.com, Casey Schaufler , Sasha Levin , jmorris@namei.org, serge@hallyn.com, linux-security-module@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 07/39] smackfs: Fix use-after-free in netlbl_catmap_walk() Date: Mon, 8 Nov 2021 20:06:17 -0500 Message-Id: <20211109010649.1191041-7-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109010649.1191041-1-sashal@kernel.org> References: <20211109010649.1191041-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pawan Gupta [ Upstream commit 0817534ff9ea809fac1322c5c8c574be8483ea57 ] Syzkaller reported use-after-free bug as described in [1]. The bug is triggered when smk_set_cipso() tries to free stale category bitmaps while there are concurrent reader(s) using the same bitmaps. Wait for RCU grace period to finish before freeing the category bitmaps in smk_set_cipso(). This makes sure that there are no more readers using the stale bitmaps and freeing them should be safe. [1] https://lore.kernel.org/netdev/000000000000a814c505ca657a4e@google.com/ Reported-by: syzbot+3f91de0b813cc3d19a80@syzkaller.appspotmail.com Signed-off-by: Pawan Gupta Signed-off-by: Casey Schaufler Signed-off-by: Sasha Levin --- security/smack/smackfs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 009e83ee2d002..25705a72d31bc 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -859,6 +859,7 @@ static int smk_open_cipso(struct inode *inode, struct file *file) static ssize_t smk_set_cipso(struct file *file, const char __user *buf, size_t count, loff_t *ppos, int format) { + struct netlbl_lsm_catmap *old_cat; struct smack_known *skp; struct netlbl_lsm_secattr ncats; char mapcatset[SMK_CIPSOLEN]; @@ -948,9 +949,11 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf, rc = smk_netlbl_mls(maplevel, mapcatset, &ncats, SMK_CIPSOLEN); if (rc >= 0) { - netlbl_catmap_free(skp->smk_netlabel.attr.mls.cat); + old_cat = skp->smk_netlabel.attr.mls.cat; skp->smk_netlabel.attr.mls.cat = ncats.attr.mls.cat; skp->smk_netlabel.attr.mls.lvl = ncats.attr.mls.lvl; + synchronize_rcu(); + netlbl_catmap_free(old_cat); rc = count; } -- 2.33.0