From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24271C433EF for ; Tue, 9 Nov 2021 01:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F147960FC2 for ; Tue, 9 Nov 2021 01:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243200AbhKIBaJ (ORCPT ); Mon, 8 Nov 2021 20:30:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:50106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243193AbhKIBXO (ORCPT ); Mon, 8 Nov 2021 20:23:14 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F027961B29; Tue, 9 Nov 2021 01:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636420123; bh=Ti0Ej9r8HZ8VAMUFsVuclQHzQJQ2MpLqfWNEcax3uI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u3FprxQabef4DLHJLisVeQ3Wo7NQBed3yWuW0TjVwoyvBNREUQKcyumkyqYrdp4L2 Op20w9rWtLy1At5l7ybLkbwQ4saioOr8xYHUxPt3wH9sB9Bvw21zBKzjH//2PgBs5p yY96riU1IZvSQYgfXRdeB8ImsOhwdlMqhOYG0V8l2FG7z3Gcjx3OM7V2WHz4JNxYBb hfhPMSAqfXhwoaLE3U8BEsbTYj88jnYpMPtq3GSiQPEwWTRYS7sfTnjD9yHYMyLpUI tip6qjRR90yLP32pJS6qF/nmv8VAcmpCeKrVQ+UOujKtKsGsQ+9aIaksJwyvN6d7bg GA9aF2qwBJIUQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Andr=C3=A9=20Almeida?= , Hans de Goede , Sebastian Reichel , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 20/33] ACPI: battery: Accept charges over the design capacity as full Date: Mon, 8 Nov 2021 20:07:54 -0500 Message-Id: <20211109010807.1191567-20-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109010807.1191567-1-sashal@kernel.org> References: <20211109010807.1191567-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: André Almeida [ Upstream commit 2835f327bd1240508db2c89fe94a056faa53c49a ] Some buggy firmware and/or brand new batteries can support a charge that's slightly over the reported design capacity. In such cases, the kernel will report to userspace that the charging state of the battery is "Unknown", when in reality the battery charge is "Full", at least from the design capacity point of view. Make the fallback condition accepts capacities over the designed capacity so userspace knows that is full. Signed-off-by: André Almeida Reviewed-by: Hans de Goede Reviewed-by: Sebastian Reichel Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 93ecae55fe6a0..69c6f02f16b5b 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -187,7 +187,7 @@ static int acpi_battery_is_charged(struct acpi_battery *battery) return 1; /* fallback to using design values for broken batteries */ - if (battery->design_capacity == battery->capacity_now) + if (battery->design_capacity <= battery->capacity_now) return 1; /* we don't do any sort of metric based on percentages */ -- 2.33.0