From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1E7C433F5 for ; Tue, 9 Nov 2021 01:28:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90BA9610E8 for ; Tue, 9 Nov 2021 01:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241732AbhKIBb2 (ORCPT ); Mon, 8 Nov 2021 20:31:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:55284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244278AbhKIBZH (ORCPT ); Mon, 8 Nov 2021 20:25:07 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3338061B3D; Tue, 9 Nov 2021 01:09:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636420189; bh=8uwzn0O37V6evak+sbd9LpuZ/CSKh5+jaonV+hgTVOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ezEDuPF7Nrj2enKUq09zl/o9nXrn7dZ3qhzv2SfM7W3cTDe7GkQKjakyWGFEmEgdp FtZK4j/CjdJPRLwQrytchjFB8f21fldDlOqbrwSl83FByFWZSaFt2UCFiO0h+j3Z9O +PPBsKYvDFz9VHm+6wAJVvh7XN8HLCcFHbcf/GQWkd1ELzZhal5+3Mg9vJ9u7W8YAy WpJYNQy0K+mbla9i871MQiXQ8rrYIwmUvlyhEH8XkaELax6niw8EE7G6oiWa9QiOL3 q1nt5tIscXlLZQspJNJWl8qxgVVvXkpkzxFKfHyXmdFybyEzI47Ly+solUoQUuvJrd cFYMopWLn9NnA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Anant Thazhemadam , syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com, Sean Young , Mauro Carvalho Chehab , Sasha Levin , mchehab@kernel.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 16/30] media: usb: dvd-usb: fix uninit-value bug in dibusb_read_eeprom_byte() Date: Mon, 8 Nov 2021 20:09:04 -0500 Message-Id: <20211109010918.1192063-16-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109010918.1192063-1-sashal@kernel.org> References: <20211109010918.1192063-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anant Thazhemadam [ Upstream commit 899a61a3305d49e8a712e9ab20d0db94bde5929f ] In dibusb_read_eeprom_byte(), if dibusb_i2c_msg() fails, val gets assigned an value that's not properly initialized. Using kzalloc() in place of kmalloc() for the buffer fixes this issue, as the val can now be set to 0 in the event dibusb_i2c_msg() fails. Reported-by: syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com Tested-by: syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com Signed-off-by: Anant Thazhemadam Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/dvb-usb/dibusb-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/dibusb-common.c b/drivers/media/usb/dvb-usb/dibusb-common.c index 7b15aea2723d6..5a1dc0d465d26 100644 --- a/drivers/media/usb/dvb-usb/dibusb-common.c +++ b/drivers/media/usb/dvb-usb/dibusb-common.c @@ -182,7 +182,7 @@ int dibusb_read_eeprom_byte(struct dvb_usb_device *d, u8 offs, u8 *val) u8 *buf; int rc; - buf = kmalloc(2, GFP_KERNEL); + buf = kzalloc(2, GFP_KERNEL); if (!buf) return -ENOMEM; -- 2.33.0