From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC559C4332F for ; Tue, 9 Nov 2021 22:38:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA7E360FDA for ; Tue, 9 Nov 2021 22:38:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345037AbhKIWlb (ORCPT ); Tue, 9 Nov 2021 17:41:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:59458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345256AbhKIWj3 (ORCPT ); Tue, 9 Nov 2021 17:39:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 95B5061B25; Tue, 9 Nov 2021 22:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636496602; bh=sQQuDsAz4XaUdqpfDeZQWEr/ejmbJZi8Sa5xGXMaYqc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ixWMElJ1HQ/PJzK70GhUO+jHcjxZqma+YJqxqmXAJ/aejHnmd1m/Rvu4W8VsbQO2Y Unt1VZuRJiEMEHW5amCctANF8u4wIVvHE8/hF1787EV0ZsjN/GVobSEq3CiYj5N/VE EMEzVELzhyMntBQRFPfrHw+4L7NWuR4+wYeUND63TzqDyQpsnuoZ88QbdxOqHHVaba 0ErKcHjQTy79WecaguwleHlRYw1KGB3rIEhhrlqE0UAXf7oUEfG505gH6TU/tPo47Q OVQmHFPKqp0Hi/zAsYGZx3fOSvyCabYArC3sq5fpip31dRVGV+GRTRQeiEk3tIFzq/ y5tI+ikqLu93Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , Greg Kroah-Hartman , Sasha Levin , balbi@ti.com, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 06/21] usb: musb: tusb6010: check return value after calling platform_get_resource() Date: Tue, 9 Nov 2021 17:22:55 -0500 Message-Id: <20211109222311.1235686-6-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109222311.1235686-1-sashal@kernel.org> References: <20211109222311.1235686-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 14651496a3de6807a17c310f63c894ea0c5d858e ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20210915034925.2399823-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/musb/tusb6010.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb/musb/tusb6010.c index 4ecfbf6bb1fa8..902507da8aa85 100644 --- a/drivers/usb/musb/tusb6010.c +++ b/drivers/usb/musb/tusb6010.c @@ -1103,6 +1103,11 @@ static int tusb_musb_init(struct musb *musb) /* dma address for async dma */ mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!mem) { + pr_debug("no async dma resource?\n"); + ret = -ENODEV; + goto done; + } musb->async = mem->start; /* dma address for sync dma */ -- 2.33.0