From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Chengfeng Ye <cyeaa@connect.ust.hk>, Takashi Iwai <tiwai@suse.de>,
Sasha Levin <sashal@kernel.org>,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org
Subject: [PATCH AUTOSEL 4.4 11/12] ALSA: gus: fix null pointer dereference on pointer block
Date: Tue, 9 Nov 2021 17:24:25 -0500 [thread overview]
Message-ID: <20211109222426.1236575-11-sashal@kernel.org> (raw)
In-Reply-To: <20211109222426.1236575-1-sashal@kernel.org>
From: Chengfeng Ye <cyeaa@connect.ust.hk>
[ Upstream commit a0d21bb3279476c777434c40d969ea88ca64f9aa ]
The pointer block return from snd_gf1_dma_next_block could be
null, so there is a potential null pointer dereference issue.
Fix this by adding a null check before dereference.
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Link: https://lore.kernel.org/r/20211024104611.9919-1-cyeaa@connect.ust.hk
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
sound/isa/gus/gus_dma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/isa/gus/gus_dma.c b/sound/isa/gus/gus_dma.c
index 36c27c8323601..2e27cd3427c87 100644
--- a/sound/isa/gus/gus_dma.c
+++ b/sound/isa/gus/gus_dma.c
@@ -141,6 +141,8 @@ static void snd_gf1_dma_interrupt(struct snd_gus_card * gus)
}
block = snd_gf1_dma_next_block(gus);
spin_unlock(&gus->dma_lock);
+ if (!block)
+ return;
snd_gf1_dma_program(gus, block->addr, block->buf_addr, block->count, (unsigned short) block->cmd);
kfree(block);
#if 0
--
2.33.0
next prev parent reply other threads:[~2021-11-09 22:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 22:24 [PATCH AUTOSEL 4.4 01/12] scsi: lpfc: Fix list_add() corruption in lpfc_drain_txq() Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 02/12] usb: musb: tusb6010: check return value after calling platform_get_resource() Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 03/12] scsi: advansys: Fix kernel pointer leak Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 04/12] ARM: dts: omap: fix gpmc,mux-add-data type Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 05/12] usb: host: ohci-tmio: check return value after calling platform_get_resource() Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 06/12] tty: tty_buffer: Fix the softlockup issue in flush_to_ldisc Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 07/12] MIPS: sni: Fix the build Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 08/12] scsi: target: Fix ordered tag handling Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 09/12] scsi: target: Fix alua_tg_pt_gps_count tracking Sasha Levin
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 10/12] powerpc/5200: dts: fix memory node unit name Sasha Levin
2021-11-09 22:24 ` Sasha Levin [this message]
2021-11-09 22:24 ` [PATCH AUTOSEL 4.4 12/12] powerpc/dcr: Use cmplwi instead of 3-argument cmpli Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109222426.1236575-11-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cyeaa@connect.ust.hk \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).