linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org
Cc: bhupesh.sharma@linaro.org, bhupesh.linux@gmail.com,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, agross@kernel.org,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	stephan@gerhold.net, Thara Gopinath <thara.gopinath@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: [PATCH v5 00/22] Enable Qualcomm Crypto Engine on sm8150 & sm8250
Date: Wed, 10 Nov 2021 16:29:00 +0530	[thread overview]
Message-ID: <20211110105922.217895-1-bhupesh.sharma@linaro.org> (raw)

Changes since v4:
=================
- v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/
- v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@linaro.org/
- Merged the sm8150 and sm8250 enablement patches in the same patchset,
  as per suggestions from Bjorn.
- Dropped a couple of patches from v4, as these have been picked by
  Bjorn already via his tree.
- Addressed review comments from Vladimir, Thara and Rob.
- Collect Reviewed-by from Rob and Thara on some of the patches from the
  v4 patchset.

Changes since v3:
=================
- v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@linaro.org/
- Dropped a couple of patches from v3, on basis of the review comments:
   ~ [PATCH 13/17] crypto: qce: core: Make clocks optional
   ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info()
- Addressed review comments from Thara, Rob and Stephan Gerhold.
- Collect Reviewed-by from Rob and Thara on some of the patches from the
  v3 patchset.

Changes since v2:
=================
- v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@linaro.org/
- Drop a couple of patches from v1, which tried to address the defered
  probing of qce driver in case bam dma driver is not yet probed.
  Replace it instead with a single (simpler) patch [PATCH 16/17].
- Convert bam dma and qce crypto dt-bindings to YAML.
- Addressed review comments from Thara, Bjorn, Vinod and Rob.

Changes since v1:
=================
- v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@linaro.org/ 
- v1 did not work well as reported earlier by Dmitry, so v2 contains the following
  changes/fixes:
  ~ Enable the interconnect path b/w BAM DMA and main memory first
    before trying to access the BAM DMA registers.
  ~ Enable the interconnect path b/w qce crytpo and main memory first
    before trying to access the qce crypto registers.
  ~ Make sure to document the required and optional properties for both
    BAM DMA and qce crypto drivers.
  ~ Add a few debug related print messages in case the qce crypto driver
    passes or fails to probe.
  ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA
    or the interconnect driver(s) (needed on specific Qualcomm parts) are not
    yet probed.

Qualcomm crypto engine is also available on sm8150 and sm8250 SoCs.
The qce block supports hardware accelerated algorithms for encryption
and authentication. It also provides support for aes, des, 3des
encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256)
authentication algorithms.

Tested the enabled crypto algorithms with cryptsetup test utilities
on sm8150-mtp, sa8155p-adp, sm8250-mtp and RB5 boards (see [1]) and
also with crypto self-tests, including the fuzz tests
 (CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y).

[1]. https://linux.die.net/man/8/cryptsetup

Cc: Thara Gopinath <thara.gopinath@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>

Bhupesh Sharma (19):
  arm64: dts: qcom: msm8996: Fix qcom,controlled-remotely property
  arm64: dts: qcom: msm8996: Fix 'dma' nodes in dts
  dt-bindings: qcom-bam: Convert binding to YAML
  dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to
    optional properties
  dt-bindings: qcom-bam: Add 'iommus' to optional properties
  dt-bindings: qcom-bam: Add "powered remotely" mode
  dt-bindings: qcom-qce: Convert bindings to yaml
  dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names'
  dt-bindings: qcom-qce: Move 'clocks' to optional properties
  dt-bindings: qcom-qce: Add 'iommus' to optional properties
  dt-bindings: crypto : Add new compatible strings for qcom-qce
  arm64/dts: qcom: Use new compatibles for crypto nodes
  crypto: qce: Add new compatibles for qce crypto driver
  crypto: qce: Print a failure msg in case probe() fails
  crypto: qce: Defer probing if BAM dma channel is not yet initialized
  crypto: qce: Add 'sm8250-qce' compatible string check
  crypto: qce: Add 'sm8150-qce' compatible string check
  arm64/dts: qcom: sm8250: Add dt entries to support crypto engine.
  arm64/dts: qcom: sm8150: Add dt entries to support crypto engine.

Thara Gopinath (3):
  dma: qcom: bam_dma: Add support to initialize interconnect path
  crypto: qce: core: Add support to initialize interconnect path
  crypto: qce: core: Make clocks optional

 .../devicetree/bindings/crypto/qcom-qce.txt   |  25 ----
 .../devicetree/bindings/crypto/qcom-qce.yaml  |  90 ++++++++++++++
 .../devicetree/bindings/dma/qcom_bam_dma.txt  |  50 --------
 .../devicetree/bindings/dma/qcom_bam_dma.yaml | 115 ++++++++++++++++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi         |   2 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |   4 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |   2 +-
 arch/arm64/boot/dts/qcom/sm8150.dtsi          |  28 +++++
 arch/arm64/boot/dts/qcom/sm8250.dtsi          |  28 +++++
 drivers/crypto/qce/core.c                     |  66 +++++++---
 drivers/crypto/qce/core.h                     |   1 +
 drivers/dma/qcom/bam_dma.c                    |  11 ++
 12 files changed, 326 insertions(+), 96 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.txt
 create mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.yaml
 delete mode 100644 Documentation/devicetree/bindings/dma/qcom_bam_dma.txt
 create mode 100644 Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml

-- 
2.31.1


             reply	other threads:[~2021-11-10 10:59 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 10:59 Bhupesh Sharma [this message]
2021-11-10 10:59 ` [PATCH v5 01/22] arm64: dts: qcom: msm8996: Fix qcom,controlled-remotely property Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 02/22] arm64: dts: qcom: msm8996: Fix 'dma' nodes in dts Bhupesh Sharma
2021-11-17  5:53   ` Vinod Koul
2021-11-10 10:59 ` [PATCH v5 03/22] dt-bindings: qcom-bam: Convert binding to YAML Bhupesh Sharma
2021-11-10 19:44   ` Rob Herring
2021-11-15  6:04     ` Bhupesh Sharma
2021-11-12  8:41   ` Vladimir Zapolskiy
2021-11-15  6:00     ` Bhupesh Sharma
2021-11-13 19:13   ` Bjorn Andersson
2021-11-15  8:05     ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 04/22] dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties Bhupesh Sharma
2021-11-18 23:52   ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 05/22] dt-bindings: qcom-bam: Add 'iommus' " Bhupesh Sharma
2021-11-18 23:52   ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 06/22] dt-bindings: qcom-bam: Add "powered remotely" mode Bhupesh Sharma
2021-11-12 10:20   ` Vladimir Zapolskiy
2021-11-10 10:59 ` [PATCH v5 07/22] dt-bindings: qcom-qce: Convert bindings to yaml Bhupesh Sharma
2021-11-13 19:41   ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 08/22] dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names' Bhupesh Sharma
2021-11-18 23:53   ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 09/22] dt-bindings: qcom-qce: Move 'clocks' to optional properties Bhupesh Sharma
2021-11-13 20:02   ` Bjorn Andersson
2021-11-15  5:34     ` Bhupesh Sharma
2021-11-18 23:57       ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 10/22] dt-bindings: qcom-qce: Add 'iommus' " Bhupesh Sharma
2021-11-13 21:23   ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 11/22] dt-bindings: crypto : Add new compatible strings for qcom-qce Bhupesh Sharma
2021-11-12 10:25   ` Vladimir Zapolskiy
2021-11-15  5:28     ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 12/22] arm64/dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
2021-11-12 10:26   ` Vladimir Zapolskiy
2021-11-15  5:04     ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 13/22] dma: qcom: bam_dma: Add support to initialize interconnect path Bhupesh Sharma
2021-11-12 10:32   ` Vladimir Zapolskiy
2021-11-15  5:27     ` Bhupesh Sharma
2021-11-15 17:53   ` Bjorn Andersson
2022-05-12 23:39   ` Dmitry Baryshkov
2021-11-10 10:59 ` [PATCH v5 14/22] crypto: qce: core: " Bhupesh Sharma
2021-11-12 10:40   ` Vladimir Zapolskiy
2021-11-15 18:25   ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 15/22] crypto: qce: Add new compatibles for qce crypto driver Bhupesh Sharma
2021-11-12 10:36   ` Vladimir Zapolskiy
2021-11-15  5:07     ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 16/22] crypto: qce: core: Make clocks optional Bhupesh Sharma
2021-11-15 18:06   ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 17/22] crypto: qce: Print a failure msg in case probe() fails Bhupesh Sharma
2021-11-12 10:42   ` Vladimir Zapolskiy
2021-11-15  5:14     ` Bhupesh Sharma
2021-11-15 18:10   ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 18/22] crypto: qce: Defer probing if BAM dma channel is not yet initialized Bhupesh Sharma
2021-11-15 18:29   ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 19/22] crypto: qce: Add 'sm8250-qce' compatible string check Bhupesh Sharma
2021-11-15 18:32   ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 20/22] crypto: qce: Add 'sm8150-qce' " Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 21/22] arm64/dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
2021-11-15 18:34   ` Bjorn Andersson
2021-11-15 20:11   ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 22/22] arm64/dts: qcom: sm8150: " Bhupesh Sharma
2022-02-11 21:49 ` [PATCH v5 00/22] Enable Qualcomm Crypto Engine on sm8150 & sm8250 Jordan Crouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110105922.217895-1-bhupesh.sharma@linaro.org \
    --to=bhupesh.sharma@linaro.org \
    --cc=agross@kernel.org \
    --cc=bhupesh.linux@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stephan@gerhold.net \
    --cc=thara.gopinath@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).