* [PATCH v1] vmscan: make drop_slab_node static
@ 2021-11-11 6:24 Gang Li
2021-11-11 13:49 ` David Hildenbrand
2021-11-12 2:13 ` Muchun Song
0 siblings, 2 replies; 3+ messages in thread
From: Gang Li @ 2021-11-11 6:24 UTC (permalink / raw)
To: Andrew Morton; +Cc: Gang Li, linux-mm, linux-kernel
drop_slab_node is only used in drop_slab. So remove it's declaration from
header file and add keyword static for it's definition.
Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
---
include/linux/mm.h | 1 -
mm/vmscan.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index a7e4a9e7d807..08b36283a57a 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -3167,7 +3167,6 @@ int drop_caches_sysctl_handler(struct ctl_table *, int, void *, size_t *,
#endif
void drop_slab(void);
-void drop_slab_node(int nid);
#ifndef CONFIG_MMU
#define randomize_va_space 0
diff --git a/mm/vmscan.c b/mm/vmscan.c
index fb9584641ac7..b02548a32a1d 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -951,7 +951,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
return freed;
}
-void drop_slab_node(int nid)
+static void drop_slab_node(int nid)
{
unsigned long freed;
int shift = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] vmscan: make drop_slab_node static
2021-11-11 6:24 [PATCH v1] vmscan: make drop_slab_node static Gang Li
@ 2021-11-11 13:49 ` David Hildenbrand
2021-11-12 2:13 ` Muchun Song
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2021-11-11 13:49 UTC (permalink / raw)
To: Gang Li, Andrew Morton; +Cc: linux-mm, linux-kernel
On 11.11.21 07:24, Gang Li wrote:
> drop_slab_node is only used in drop_slab. So remove it's declaration from
> header file and add keyword static for it's definition.
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
> include/linux/mm.h | 1 -
> mm/vmscan.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index a7e4a9e7d807..08b36283a57a 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -3167,7 +3167,6 @@ int drop_caches_sysctl_handler(struct ctl_table *, int, void *, size_t *,
> #endif
>
> void drop_slab(void);
> -void drop_slab_node(int nid);
>
> #ifndef CONFIG_MMU
> #define randomize_va_space 0
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index fb9584641ac7..b02548a32a1d 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -951,7 +951,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
> return freed;
> }
>
> -void drop_slab_node(int nid)
> +static void drop_slab_node(int nid)
> {
> unsigned long freed;
> int shift = 0;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] vmscan: make drop_slab_node static
2021-11-11 6:24 [PATCH v1] vmscan: make drop_slab_node static Gang Li
2021-11-11 13:49 ` David Hildenbrand
@ 2021-11-12 2:13 ` Muchun Song
1 sibling, 0 replies; 3+ messages in thread
From: Muchun Song @ 2021-11-12 2:13 UTC (permalink / raw)
To: Gang Li; +Cc: Andrew Morton, Linux Memory Management List, LKML
On Thu, Nov 11, 2021 at 2:25 PM Gang Li <ligang.bdlg@bytedance.com> wrote:
>
> drop_slab_node is only used in drop_slab. So remove it's declaration from
> header file and add keyword static for it's definition.
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-12 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 6:24 [PATCH v1] vmscan: make drop_slab_node static Gang Li
2021-11-11 13:49 ` David Hildenbrand
2021-11-12 2:13 ` Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).