From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2DAC433F5 for ; Fri, 12 Nov 2021 06:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C2FC604DA for ; Fri, 12 Nov 2021 06:42:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232791AbhKLGp3 (ORCPT ); Fri, 12 Nov 2021 01:45:29 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:58174 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbhKLGp1 (ORCPT ); Fri, 12 Nov 2021 01:45:27 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1AC6gUr7056414; Fri, 12 Nov 2021 00:42:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1636699350; bh=1P38wV/BK74lYrHDkeWs2IVOShjF3pDbyYeEWfZZ0D0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=qB+dbLhmXC/HK0CRWnlCQNpu7m7uvzFQJ4U0EK0Nf0c59PeVoNStUgSByoQEEfpZZ UpCg/6gIkT3petBzN19W1jbJJfzYuZqMOuhBArp9jvLjbuIMC9KuJHjnzasjNT7T51 xvcegTvRfQ2+b8bD6irThRrsaj6gKbOO4g1mkYzc= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1AC6gUME082454 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Nov 2021 00:42:30 -0600 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 12 Nov 2021 00:42:30 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 12 Nov 2021 00:42:30 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1AC6gUeb049000; Fri, 12 Nov 2021 00:42:30 -0600 Date: Fri, 12 Nov 2021 00:42:30 -0600 From: Nishanth Menon To: Vihas Mak CC: , , , Subject: Re: [PATCH] soc: ti: Use DEFINE_DEBUGFS_ATTRIBUTE Message-ID: <20211112064230.c6acyxudgbs7lmsf@predator> References: <20211110191707.GA98778@makvihas> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20211110191707.GA98778@makvihas> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 00:47-20211111, Vihas Mak wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE as > pm_sr_fops is used to create a debugfs file. > > This solves following warning generated by coccicheck: > > ./drivers/soc/ti/smartreflex.c:815:0-23: WARNING: pm_sr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Signed-off-by: Vihas Mak > --- > drivers/soc/ti/smartreflex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c > index b5b2fa538..14b69307d 100644 > --- a/drivers/soc/ti/smartreflex.c > +++ b/drivers/soc/ti/smartreflex.c > @@ -812,7 +812,7 @@ static int omap_sr_autocomp_store(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > omap_sr_autocomp_store, "%llu\n"); > Same as https://lore.kernel.org/linux-arm-kernel/1619523673-120782-1-git-send-email-yang.lee@linux.alibaba.com/ Santosh: could you pick the original patch up? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D