From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel.vetter@ffwll.ch, arnd@arndb.de,
gregkh@linuxfoundation.org,
James.Bottomley@HansenPartnership.com, deller@gmx.de
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 5/7] agp/nvidia: Ignore value returned by readl()
Date: Fri, 12 Nov 2021 15:16:26 +0100 [thread overview]
Message-ID: <20211112141628.12904-6-tzimmermann@suse.de> (raw)
In-Reply-To: <20211112141628.12904-1-tzimmermann@suse.de>
Fix the compiler warning
drivers/char/agp/nvidia-agp.c: In function 'nvidia_tlbflush':
drivers/char/agp/nvidia-agp.c:264:22: warning: variable 'temp' set but not used [-Wunused-but-set-variable]
264 | u32 wbc_reg, temp;
by removing the unused variable. The affected readl() is only
required for flushing caches, but the returned value is not of
interest.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/char/agp/nvidia-agp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/agp/nvidia-agp.c b/drivers/char/agp/nvidia-agp.c
index f78e756157db..437b3581cbe5 100644
--- a/drivers/char/agp/nvidia-agp.c
+++ b/drivers/char/agp/nvidia-agp.c
@@ -261,7 +261,7 @@ static int nvidia_remove_memory(struct agp_memory *mem, off_t pg_start, int type
static void nvidia_tlbflush(struct agp_memory *mem)
{
unsigned long end;
- u32 wbc_reg, temp;
+ u32 wbc_reg;
int i;
/* flush chipset */
@@ -283,9 +283,9 @@ static void nvidia_tlbflush(struct agp_memory *mem)
/* flush TLB entries */
for (i = 0; i < 32 + 1; i++)
- temp = readl(nvidia_private.aperture+(i * PAGE_SIZE / sizeof(u32)));
+ (void)readl(nvidia_private.aperture+(i * PAGE_SIZE / sizeof(u32)));
for (i = 0; i < 32 + 1; i++)
- temp = readl(nvidia_private.aperture+(i * PAGE_SIZE / sizeof(u32)));
+ (void)readl(nvidia_private.aperture+(i * PAGE_SIZE / sizeof(u32)));
}
--
2.33.1
next prev parent reply other threads:[~2021-11-12 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:16 [PATCH 0/7] agp: Various minor fixes Thomas Zimmermann
2021-11-12 14:16 ` [PATCH 1/7] agp: Remove trailing whitespaces Thomas Zimmermann
2021-11-12 14:16 ` [PATCH 2/7] agp: Include "compat_ioctl.h" where necessary Thomas Zimmermann
2021-11-12 14:16 ` [PATCH 3/7] agp: Documentation fixes Thomas Zimmermann
2021-11-12 14:16 ` [PATCH 4/7] agp/ati: Return error from ati_create_page_map() Thomas Zimmermann
2021-11-30 10:11 ` Helge Deller
2021-11-12 14:16 ` Thomas Zimmermann [this message]
2021-11-30 10:13 ` [PATCH 5/7] agp/nvidia: Ignore value returned by readl() Helge Deller
2021-11-12 14:16 ` [PATCH 6/7] agp/sworks: Remove unused variable 'current_size' Thomas Zimmermann
2021-11-12 14:16 ` [PATCH 7/7] agp/via: " Thomas Zimmermann
2021-11-30 10:03 ` [PATCH 0/7] agp: Various minor fixes Thomas Zimmermann
2021-11-30 10:17 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112141628.12904-6-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).