From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <robh+dt@kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] dt-bindings:iio:filter: add admv8818 doc
Date: Fri, 12 Nov 2021 17:46:01 +0000 [thread overview]
Message-ID: <20211112174601.3c1f6b4b@jic23-huawei> (raw)
In-Reply-To: <20211109123127.96399-4-antoniu.miclaus@analog.com>
On Tue, 9 Nov 2021 14:31:26 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Add device tree bindings for the ADMV8818 Filter.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> .../bindings/iio/filter/adi,admv8818.yaml | 78 +++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> new file mode 100644
> index 000000000000..d581e236dbdc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/filter/adi,admv8818.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADMV8818 Digitally Tunable, High-Pass and Low-Pass Filter
> +
> +maintainers:
> + - Antoniu Miclaus <antoniu.miclaus@analog.com>
> +
> +description: |
> + Fully monolithic microwave integrated circuit (MMIC) that
> + features a digitally selectable frequency of operation.
> + The device features four independently controlled high-pass
> + filters (HPFs) and four independently controlled low-pass filters
> + (LPFs) that span the 2 GHz to 18 GHz frequency range.
> +
> + https://www.analog.com/en/products/admv8818.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,admv8818
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 10000000
> +
> + clocks:
> + description:
> + Definition of the external clock.
> + minItems: 1
> +
> + clock-names:
> + items:
> + - const: "rf_in"
Is this what we'd normally think of as a clock signal? I'd not expect
a nice squarewave on that pin for example so this seems an odd way to
define it.
> +
> + clock-output-names:
> + maxItems: 1
> +
> + adi,bw-hz:
> + description:
> + Allows the user to increase the Bandpass Filter (BPF) bandwidth
> + in Hz. Normally when invoked by the clk notifier, the driver
> + sets the HPF cutoff close below the frequency and the LPF cutoff
> + close above the frequency, and thus creating a BPF.
I don't understand this item at all. Why do we need a control to
basically change how the other filter parameters are expressed?
> + $ref: /schemas/types.yaml#/definitions/uint64
> +
> + '#clock-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + admv8818@0 {
> + compatible = "adi,admv8818";
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + clocks = <&admv8818_rfin>;
> + clock-names = "rf_in";
> + adi,bw-hz = /bits/ 64 <600000000>;
> + };
> + };
> +...
> +
next prev parent reply other threads:[~2021-11-12 17:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 12:31 [PATCH 0/4] Add support for ADMV8818 Antoniu Miclaus
2021-11-09 12:31 ` [PATCH 1/4] iio: add filter subfolder Antoniu Miclaus
2021-11-12 17:36 ` Jonathan Cameron
2021-11-12 17:44 ` Jonathan Cameron
2021-11-09 12:31 ` [PATCH 2/4] iio:filter:admv8818: add support for ADMV8818 Antoniu Miclaus
2021-11-12 18:06 ` Jonathan Cameron
2021-11-09 12:31 ` [PATCH 3/4] dt-bindings:iio:filter: add admv8818 doc Antoniu Miclaus
2021-11-10 1:07 ` Rob Herring
2021-11-10 9:39 ` Miclaus, Antoniu
2021-11-12 17:46 ` Jonathan Cameron [this message]
2021-11-16 14:43 ` Miclaus, Antoniu
2021-11-21 12:24 ` Jonathan Cameron
2021-11-09 12:31 ` [PATCH 4/4] iio:filter:admv8818: Add sysfs ABI documentation Antoniu Miclaus
2021-11-12 17:56 ` Jonathan Cameron
2021-11-12 18:05 ` Jonathan Cameron
2021-11-16 14:43 ` Miclaus, Antoniu
2021-11-21 12:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112174601.3c1f6b4b@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).