Hi Wells, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on net/master robh/for-next linus/master v5.15 next-20211112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Wells-Lu/devicetree-bindings-net-Add-bindings-doc-for-Sunplus-SP7021/20211111-180647 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cc0356d6a02e064387c16a83cb96fe43ef33181e config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/67fef21f20f9dd81655eb490c5fa41c075f4af3d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Wells-Lu/devicetree-bindings-net-Add-bindings-doc-for-Sunplus-SP7021/20211111-180647 git checkout 67fef21f20f9dd81655eb490c5fa41c075f4af3d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/net/ethernet/sunplus/sp_driver.c:200:7: error: no previous prototype for 'sp7021_otp_read_mac' [-Werror=missing-prototypes] 200 | char *sp7021_otp_read_mac(struct device *dev, ssize_t *len, char *name) | ^~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors vim +/sp7021_otp_read_mac +200 drivers/net/ethernet/sunplus/sp_driver.c 199 > 200 char *sp7021_otp_read_mac(struct device *dev, ssize_t *len, char *name) 201 { 202 char *ret = NULL; 203 struct nvmem_cell *cell = nvmem_cell_get(dev, name); 204 205 if (IS_ERR_OR_NULL(cell)) { 206 dev_err(dev, "OTP %s read failure: %ld", name, PTR_ERR(cell)); 207 return NULL; 208 } 209 210 ret = nvmem_cell_read(cell, len); 211 nvmem_cell_put(cell); 212 dev_dbg(dev, "%zd bytes are read from OTP %s.", *len, name); 213 214 return ret; 215 } 216 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org