From: Lukas Wunner <lukas@wunner.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pciehp: fast unplug for virtual machines
Date: Mon, 15 Nov 2021 08:45:42 +0100 [thread overview]
Message-ID: <20211115074542.GA24942@wunner.de> (raw)
In-Reply-To: <20211114173550-mutt-send-email-mst@kernel.org> <20211114122249-mutt-send-email-mst@kernel.org>
On Sun, Nov 14, 2021 at 05:37:15PM -0500, Michael S. Tsirkin wrote:
> On Sun, Nov 14, 2021 at 07:06:04PM +0100, Lukas Wunner wrote:
> > Why don't you just trigger surprise-removal from outside the guest?
>
> Because linux does not handle it well for all devices. Fixing that
> requires fixing all drivers.
Please expose surprise removal in addition to the Attention Button
to avoid perpetuating this situation. Teach users to use that for
devices whose drivers already support it well and fall back to the
Attention Button only for those that don't.
macOS and Windows support surprise-removal of most hardware well.
We've made a lot of progress in that area (AMD for one has been
working on surprise removal of GPUs). It's an embarrassment if
contortions such as abusing the Attention Button are needed just
because surprise removal doesn't work for everything. I'd like
to see engineering resources spent on fixing surprise removal for
drivers that are relevant for you, rather than implementing
workarounds such as this one.
Thanks,
Lukas
next prev parent reply other threads:[~2021-11-15 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 9:02 [PATCH] pciehp: fast unplug for virtual machines Gerd Hoffmann
2021-11-11 17:00 ` Michael S. Tsirkin
2021-11-12 9:56 ` Gerd Hoffmann
2021-11-12 10:09 ` Michael S. Tsirkin
2021-11-11 21:50 ` Bjorn Helgaas
2021-11-12 11:28 ` Gerd Hoffmann
2021-11-12 0:00 ` Krzysztof Wilczyński
2021-11-14 16:39 ` Lukas Wunner
2021-11-14 17:24 ` Michael S. Tsirkin
2021-11-14 18:06 ` Lukas Wunner
2021-11-14 22:37 ` Michael S. Tsirkin
2021-11-15 9:59 ` Gerd Hoffmann
2021-11-15 7:45 ` Lukas Wunner [this message]
2021-11-15 10:09 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115074542.GA24942@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).