From: Kees Cook <keescook@chromium.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Tony Luck <tony.luck@intel.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pstore/blk: Use "%lu" to format unsigned long
Date: Mon, 15 Nov 2021 16:49:18 -0800 [thread overview]
Message-ID: <202111151648.0498D0AE@keescook> (raw)
In-Reply-To: <CAMuHMdWwDK0bB2B7iFXqMhkZrmw26vKDFZEv+z+mYYTavp5-Eg@mail.gmail.com>
On Mon, Nov 15, 2021 at 08:58:51AM +0100, Geert Uytterhoeven wrote:
> Hi Kees,
>
> On Tue, Jun 29, 2021 at 11:12 PM Kees Cook <keescook@chromium.org> wrote:
> > On Tue, 29 Jun 2021 12:37:00 +0200, Geert Uytterhoeven wrote:
> > > On 32-bit:
> > >
> > > fs/pstore/blk.c: In function ‘__best_effort_init’:
> > > include/linux/kern_levels.h:5:18: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
> > > 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
> > > | ^~~~~~
> > > include/linux/kern_levels.h:14:19: note: in expansion of macro ‘KERN_SOH’
> > > 14 | #define KERN_INFO KERN_SOH "6" /* informational */
> > > | ^~~~~~~~
> > > include/linux/printk.h:373:9: note: in expansion of macro ‘KERN_INFO’
> > > 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > > | ^~~~~~~~~
> > > fs/pstore/blk.c:314:3: note: in expansion of macro ‘pr_info’
> > > 314 | pr_info("attached %s (%zu) (no dedicated panic_write!)\n",
> > > | ^~~~~~~
> >
> > Applied to for-next/pstore, thanks!
>
> Thanks!
>
> > [1/1] pstore/blk: Use "%lu" to format unsigned long
> > https://git.kernel.org/kees/c/c5d4fb2539ca
>
> Looks like this still hasn't made upstream, although it has been in
> linux-next since the end of June? The issue is still present (and
> now an error with -Werror), but hidden due to commit d07f3b081ee63226
> ("mark pstore-blk as broken").
Argh, I didn't notice that d07f3b081ee63226 actually landed upstream. It
was not supposed to land since pstore-blk got fixed before the merge
window. Bleh. I will try to get this all sorted out.
-Kees
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Kees Cook
next prev parent reply other threads:[~2021-11-16 4:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 10:37 [PATCH] pstore/blk: Use "%lu" to format unsigned long Geert Uytterhoeven
2021-06-29 21:12 ` Kees Cook
2021-11-15 7:58 ` Geert Uytterhoeven
2021-11-16 0:49 ` Kees Cook [this message]
2021-11-18 18:26 Kees Cook
2021-11-19 6:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111151648.0498D0AE@keescook \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).