From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84130C41535 for ; Mon, 15 Nov 2021 19:27:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69DA361A3A for ; Mon, 15 Nov 2021 19:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244707AbhKOTRR (ORCPT ); Mon, 15 Nov 2021 14:17:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:57918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238584AbhKORpF (ORCPT ); Mon, 15 Nov 2021 12:45:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1F74661BA9; Mon, 15 Nov 2021 17:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636997334; bh=wRE2yNrIz8C5NzEayyu6jiWpgX0Wpn6MEenl9TcxeLY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xabneVNCa7WQhI5JMYlKmeFoXeapnaTttnDEVKGuZ5eOlKneucSuXgQ62kGw6ffFG Dp/HhjxCgxSmmcisjPdkxNbyvXfqpHo8j17aq8dF+HLI4rZI0YNqaaqbEfFrv/YzX5 SAxpWmIxTXGaQVczSEniLtEaeldVOd75lBJdgF2A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dongli Zhang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 078/575] vmxnet3: do not stop tx queues after netif_device_detach() Date: Mon, 15 Nov 2021 17:56:43 +0100 Message-Id: <20211115165346.330443346@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211115165343.579890274@linuxfoundation.org> References: <20211115165343.579890274@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongli Zhang [ Upstream commit 9159f102402a64ac85e676b75cc1f9c62c5b4b73 ] The netif_device_detach() conditionally stops all tx queues if the queues are running. There is no need to call netif_tx_stop_all_queues() again. Signed-off-by: Dongli Zhang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/vmxnet3/vmxnet3_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 336504b7531d9..932a39945cc62 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -3765,7 +3765,6 @@ vmxnet3_suspend(struct device *device) vmxnet3_free_intr_resources(adapter); netif_device_detach(netdev); - netif_tx_stop_all_queues(netdev); /* Create wake-up filters. */ pmConf = adapter->pm_conf; -- 2.33.0