From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9083EC4332F for ; Mon, 15 Nov 2021 23:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 797D961A8D for ; Mon, 15 Nov 2021 23:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351259AbhKOXSI (ORCPT ); Mon, 15 Nov 2021 18:18:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:42978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244390AbhKOTOE (ORCPT ); Mon, 15 Nov 2021 14:14:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E7F163407; Mon, 15 Nov 2021 18:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637000434; bh=Fh3BaZ0DrrSuADIrk2Dg1oQnjILv2qUDrUG5Qt9acAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xts3k0wLvU2icgOdoco6JOptAxlK69kPCz1bboVZq3JROeq8qFrmf8gbiwBWN1Y2V cKXgFHW0ql7A70KJ/GvoFWRrEIB1to0Hahyk3xZfnIJjDFUsY+YSCS40Eb9H9LDooI i4WVxvW4LRSChE0OVmZxWEG/pZLv/CZMKXN4IWZI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Kuninori Morimoto , Mark Brown , Sasha Levin Subject: [PATCH 5.14 658/849] ASoC: rsnd: Fix an error handling path in rsnd_node_count() Date: Mon, 15 Nov 2021 18:02:21 +0100 Message-Id: <20211115165442.522891861@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211115165419.961798833@linuxfoundation.org> References: <20211115165419.961798833@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 173632358fde7a567f28e07c4549b959ee857986 ] If we return before the end of the 'for_each_child_of_node()' iterator, the reference taken on 'np' must be released. Add the missing 'of_node_put()' call. Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module") Signed-off-by: Christophe JAILLET Reviewed-by: Kuninori Morimoto Link: https://lore.kernel.org/r/4c0e893cbfa21dc76c1ede0b6f4f8cff42209299.1634586167.git.christophe.jaillet@wanadoo.fr Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/sh/rcar/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 5e382b5c9d457..ece9b58ab52d3 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -1225,6 +1225,7 @@ int rsnd_node_count(struct rsnd_priv *priv, struct device_node *node, char *name if (i < 0) { dev_err(dev, "strange node numbering (%s)", of_node_full_name(node)); + of_node_put(np); return 0; } i++; -- 2.33.0