From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Amit Cohen <amcohen@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] devlink: Remove extra assertion from flash notification logic
Date: Mon, 15 Nov 2021 17:15:30 -0800 [thread overview]
Message-ID: <20211115171530.432f5753@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YZKmlzhu0gtKpvXW@unreal>
On Mon, 15 Nov 2021 20:27:35 +0200 Leon Romanovsky wrote:
> On Mon, Nov 15, 2021 at 10:14:37AM -0800, Jakub Kicinski wrote:
> > On Mon, 15 Nov 2021 20:07:47 +0200 Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@nvidia.com>
> > >
> > > The mlxsw driver calls to various devlink flash routines even before
> > > users can get any access to the devlink instance itself. For example,
> > > mlxsw_core_fw_rev_validate() one of such functions.
> > >
> > > It causes to the WARN_ON to trigger warning about devlink not
> > > registered, while the flow is valid.
> >
> > So the fix is to remove the warning and keep generating notifications
> > about objects which to the best understanding of the user space do not
> > exist?
>
> If we delay this mlxsw specific notification, the user will get
> DEVLINK_CMD_FLASH_UPDATE and DEVLINK_CMD_FLASH_UPDATE_END at the
> same time. I didn't like this, probably users won't like it either,
> so decided to go with less invasive solution as possible.
I'd drop these notifications, the user didn't ask to flash the device,
it's just code reuse in the driver, right?
next prev parent reply other threads:[~2021-11-16 1:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 18:07 [PATCH net] devlink: Remove extra assertion from flash notification logic Leon Romanovsky
2021-11-15 18:14 ` Jakub Kicinski
2021-11-15 18:27 ` Leon Romanovsky
2021-11-16 1:15 ` Jakub Kicinski [this message]
2021-11-17 13:23 ` Leon Romanovsky
2021-11-17 14:02 ` Jakub Kicinski
2021-11-17 14:38 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115171530.432f5753@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).