Re: [PATCH V1] mmc: sdhci-msm: Add eMMC and SD card err_stat sysfs entry

From: kernel test robot <lkp@intel.com>
To: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>,
	adrian.hunter@intel.com, riteshh@codeaurora.org,
	asutoshd@quicinc.com, ulf.hansson@linaro.org, agross@kernel.org,
	bjorn.andersson@linaro.org, linux-mmc@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, stummala@codeaurora.org
Subject: Re: [PATCH V1] mmc: sdhci-msm: Add eMMC and SD card err_stat sysfs entry
Date: Wed, 17 Nov 2021 21:39:37 +0800	[thread overview]
Message-ID: <202111172148.UsyHG8ZD-lkp@intel.com> (raw)
In-Reply-To: <1637130012-21846-1-git-send-email-quic_c_sbhanu@quicinc.com>

[-- Attachment #1: Type: text/plain, Size: 2575 bytes --]

Hi Shaik,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.16-rc1 next-20211117]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shaik-Sajida-Bhanu/mmc-sdhci-msm-Add-eMMC-and-SD-card-err_stat-sysfs-entry/20211117-142139
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8ab774587903771821b59471cc723bba6d893942
config: nios2-randconfig-r025-20211117 (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a840d7ed5c9df9bad36a213ed67a131251770770
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shaik-Sajida-Bhanu/mmc-sdhci-msm-Add-eMMC-and-SD-card-err_stat-sysfs-entry/20211117-142139
        git checkout a840d7ed5c9df9bad36a213ed67a131251770770
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/mmc/host/sdhci-msm.c:2128:6: warning: no previous prototype for 'sdhci_msm_cqe_err_stats' [-Wmissing-prototypes]
    2128 | void sdhci_msm_cqe_err_stats(struct mmc_host *mmc, unsigned long flags)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mmc/host/sdhci-msm.c:2439:6: warning: no previous prototype for 'sdhci_msm_err_stats' [-Wmissing-prototypes]
    2439 | void sdhci_msm_err_stats(struct sdhci_host *host, u32 intmask)
         |      ^~~~~~~~~~~~~~~~~~~

vim +/sdhci_msm_cqe_err_stats +2128 drivers/mmc/host/sdhci-msm.c

  2127	
> 2128	void sdhci_msm_cqe_err_stats(struct mmc_host *mmc, unsigned long flags)
  2129	{
  2130		struct sdhci_host *host = mmc_priv(mmc);
  2131		struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
  2132		struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host);
  2133	
  2134		if (flags & BIT(0))
  2135			msm_host->err_stats[MMC_ERR_CMDQ_REQ_TIMEOUT]++;
  2136	}
  2137	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24125 bytes --]