linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Lorenz Bauer <lmb@cloudflare.com>
Cc: Shuah Khan <shuah@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	kernel-team <kernel-team@cloudflare.com>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf] selftests: bpf: check map in map pruning
Date: Wed, 17 Nov 2021 17:00:59 -0800	[thread overview]
Message-ID: <20211118010059.c2mixoshcrcz4ywq@ast-mbp> (raw)
In-Reply-To: <CACAyw99EhJ8k4f3zeQMf3pRC+L=hQhK=Rb3UwSz19wt9gnMPrA@mail.gmail.com>

On Wed, Nov 17, 2021 at 08:47:45AM +0000, Lorenz Bauer wrote:
> On Sat, 13 Nov 2021 at 01:27, Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> >
> > Not sure how you've tested it, but it doesn't work in unpriv:
> > $ test_verifier 789
> > #789/u map in map state pruning FAIL
> > processed 26 insns (limit 1000000) max_states_per_insn 0 total_states
> > 2 peak_states 2 mark_read 1
> > #789/p map in map state pruning OK
> 
> Strange, I have a script that I use for bisecting which uses a minimal
> .config + virtue to run a vm, plus I was debugging in gdb at the same
> time. I might have missed this, apologies.
> 
> I guess vmtest.sh is the canonical way to run tests now?

vmtest.sh runs test_progs only. That's the minimum bar that
developers have to pass before sending patches.
BPF CI runs test_progs, test_progs-no_alu32, test_verifier and test_maps.
If in doubt run them all.

  reply	other threads:[~2021-11-18  1:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 16:14 [PATCH bpf] selftests: bpf: check map in map pruning Lorenz Bauer
2021-11-12 15:20 ` patchwork-bot+netdevbpf
2021-11-13  1:27 ` Alexei Starovoitov
2021-11-17  8:47   ` Lorenz Bauer
2021-11-18  1:00     ` Alexei Starovoitov [this message]
2021-11-18  1:29       ` Andrii Nakryiko
2021-11-18  1:38         ` Andrii Nakryiko
2021-11-18 11:05           ` Ilya Leoshkevich
2021-11-18 11:56           ` Ilya Leoshkevich
2021-11-18 15:20             ` KP Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211118010059.c2mixoshcrcz4ywq@ast-mbp \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@cloudflare.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).