From: Manivannan Sadhasivam <mani@kernel.org>
To: Bhaumik Bhatt <quic_bbhatt@quicinc.com>
Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
quic_hemantk@quicinc.com, linux-kernel@vger.kernel.org,
loic.poulain@linaro.org
Subject: Re: [PATCH] bus: mhi: core: Read missing channel configuration entry
Date: Thu, 18 Nov 2021 11:37:20 +0530 [thread overview]
Message-ID: <20211118060720.GC6461@thinkpad> (raw)
In-Reply-To: <1636072273-16034-1-git-send-email-quic_bbhatt@quicinc.com>
On Thu, Nov 04, 2021 at 05:31:13PM -0700, Bhaumik Bhatt wrote:
> The 'wake-capable' entry in channel configuration is not set when
> parsing the configuration specified by the controller driver. Add
> the missing entry to ensure channel is correctly specified as a
> 'wake-capable' channel.
>
> Signed-off-by: Bhaumik Bhatt <quic_bbhatt@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Looks like this one is qualified as a bug fix. Please add the fixes tag and Cc
stable.
And the subject could be,
"bus: mhi: core: Fix reading wake_capable configuration"
Thanks,
Mani
> ---
> drivers/bus/mhi/core/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 5aaca6d..f1ec3441 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -788,6 +788,7 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> + mhi_chan->wake_capable = ch_cfg->wake_capable;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2021-11-18 6:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 0:31 [PATCH] bus: mhi: core: Read missing channel configuration entry Bhaumik Bhatt
2021-11-06 1:35 ` Hemant Kumar
2021-11-18 6:07 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118060720.GC6461@thinkpad \
--to=mani@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_bbhatt@quicinc.com \
--cc=quic_hemantk@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).