From: cgel.zte@gmail.com
To: pdeschrijver@nvidia.com
Cc: jonathanh@nvidia.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
mturquette@baylibre.com, pgaikwad@nvidia.com, sboyd@kernel.org,
thierry.reding@gmail.com, zealci@zte.com.cn, cgel.zte@gmail.com,
deng.changcheng@zte.com.cn
Subject: [PATCH v2] clk: tegra: Use div64_ul instead of do_div
Date: Thu, 18 Nov 2021 07:41:01 +0000 [thread overview]
Message-ID: <20211118074101.165168-1-deng.changcheng@zte.com.cn> (raw)
In-Reply-To: <20211117014714.159005-1-deng.changcheng@zte.com.cn>
From: Changcheng Deng <deng.changcheng@zte.com.cn>
do_div() does a 64-by-32 division. Here the divisor is an unsigned long
which on some platforms is 64 bit wide. So use div64_ul instead of do_div
to avoid a possible truncation.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/clk/tegra/clk-utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-utils.c b/drivers/clk/tegra/clk-utils.c
index 1a5daae4e501..12658add9dd7 100644
--- a/drivers/clk/tegra/clk-utils.c
+++ b/drivers/clk/tegra/clk-utils.c
@@ -26,7 +26,7 @@ int div_frac_get(unsigned long rate, unsigned parent_rate, u8 width,
if (flags & TEGRA_DIVIDER_ROUND_UP)
divider_ux1 += rate - 1;
- do_div(divider_ux1, rate);
+ divider_ux1 = div64_ul(divider_ux1, rate);
if (flags & TEGRA_DIVIDER_INT)
divider_ux1 *= mul;
--
2.25.1
prev parent reply other threads:[~2021-11-18 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 1:47 [PATCH] clk: tegra: Use div64_ul instead of do_div cgel.zte
2021-11-18 7:41 ` cgel.zte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118074101.165168-1-deng.changcheng@zte.com.cn \
--to=cgel.zte@gmail.com \
--cc=deng.changcheng@zte.com.cn \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).