From: Mark Rutland <mark.rutland@arm.com>
To: Jisheng Zhang <jszhang3@mail.ustc.edu.cn>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: extable: remove unsed ex_handler_t definition
Date: Thu, 18 Nov 2021 15:13:28 +0000 [thread overview]
Message-ID: <20211118151317.GA9977@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20211118200249.73172ce5@xhacker>
On Thu, Nov 18, 2021 at 08:02:49PM +0800, Jisheng Zhang wrote:
> From: Jisheng Zhang <jszhang@kernel.org>
>
> The type ex_handler_t is defined but not used, remove it.
It's probably worth saying:
| The ex_handler_t type was introduced in commit:
|
| d6e2cc5647753825 ("arm64: extable: add `type` and `data` fields")
|
| ... but has never been used, and is unnecessary. Remove it.
... as this was a leftover from a prior version of that patch, and in
the form merged in mainline it was redundant becuase we moved to using
an enumerated type rather than a function pointer in the ex_table_entry.
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
With or without the wording above:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> arch/arm64/mm/extable.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/mm/extable.c b/arch/arm64/mm/extable.c
> index c3d53811a15e..c0181e60cc98 100644
> --- a/arch/arm64/mm/extable.c
> +++ b/arch/arm64/mm/extable.c
> @@ -10,9 +10,6 @@
> #include <asm/asm-extable.h>
> #include <asm/ptrace.h>
>
> -typedef bool (*ex_handler_t)(const struct exception_table_entry *,
> - struct pt_regs *);
> -
> static inline unsigned long
> get_ex_fixup(const struct exception_table_entry *ex)
> {
> --
> 2.33.0
>
>
prev parent reply other threads:[~2021-11-18 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 12:02 [PATCH] arm64: extable: remove unsed ex_handler_t definition Jisheng Zhang
2021-11-18 15:13 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118151317.GA9977@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=jszhang3@mail.ustc.edu.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).