From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69D7DC433F5 for ; Fri, 19 Nov 2021 18:43:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5028861056 for ; Fri, 19 Nov 2021 18:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235664AbhKSSq5 (ORCPT ); Fri, 19 Nov 2021 13:46:57 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34907 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234697AbhKSSq4 (ORCPT ); Fri, 19 Nov 2021 13:46:56 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E4E21FF805; Fri, 19 Nov 2021 18:43:51 +0000 (UTC) From: Miquel Raynal To: Paul Cercueil , Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Harvey Hunt , list@opendingux.net, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 5/5] mtd: rawnand/ingenic: JZ4740 needs 'oob_first' read page function Date: Fri, 19 Nov 2021 19:43:51 +0100 Message-Id: <20211119184351.1404360-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20211016132228.40254-5-paul@crapouillou.net> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'0171480007d64f663aae9226303f1b1e4621229e' Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-10-16 at 13:22:28 UTC, Paul Cercueil wrote: > The ECC engine on the JZ4740 SoC requires the ECC data to be read before > the page; using the default page reading function does not work. Indeed, > the old JZ4740 NAND driver (removed in 5.4) did use the 'OOB first' flag > that existed back then. > > Use the newly created nand_read_page_hwecc_oob_first() to address this > issue. > > This issue was not found when the new ingenic-nand driver was developed, > most likely because the Device Tree used had the nand-ecc-mode set to > "hw_oob_first", which seems to not be supported anymore. > > Cc: # v5.2 > Fixes: a0ac778eb82c ("mtd: rawnand: ingenic: Add support for the JZ4740") > Signed-off-by: Paul Cercueil Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel