* [PATCH] crypto:otx2_cptvf_algs: use swap() to make code cleaner
@ 2021-11-09 8:35 cgel.zte
2021-11-20 4:31 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: cgel.zte @ 2021-11-09 8:35 UTC (permalink / raw)
To: bbrezillon
Cc: arno, schalla, herbert, davem, lbartosik, chi.minghao, schandran,
ebiggers, ovidiu.panait, linux-crypto, linux-kernel, Zeal Robot
From: chiminghao <chi.minghao@zte.com.cn>
Fix the following coccicheck REVIEW:
./drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c:1688:16-17 use swap() to make code cleaner
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: chiminghao <chi.minghao@zte.com.cn>
---
drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c b/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
index 877a948469bd..2748a3327e39 100644
--- a/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
+++ b/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
@@ -1682,11 +1682,8 @@ static void swap_func(void *lptr, void *rptr, int size)
{
struct cpt_device_desc *ldesc = lptr;
struct cpt_device_desc *rdesc = rptr;
- struct cpt_device_desc desc;
- desc = *ldesc;
- *ldesc = *rdesc;
- *rdesc = desc;
+ swap(*ldesc, *rdesc);
}
int otx2_cpt_crypto_init(struct pci_dev *pdev, struct module *mod,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto:otx2_cptvf_algs: use swap() to make code cleaner
2021-11-09 8:35 [PATCH] crypto:otx2_cptvf_algs: use swap() to make code cleaner cgel.zte
@ 2021-11-20 4:31 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2021-11-20 4:31 UTC (permalink / raw)
To: cgel.zte
Cc: bbrezillon, arno, schalla, davem, lbartosik, chi.minghao,
schandran, ebiggers, ovidiu.panait, linux-crypto, linux-kernel,
Zeal Robot
On Tue, Nov 09, 2021 at 08:35:03AM +0000, cgel.zte@gmail.com wrote:
> From: chiminghao <chi.minghao@zte.com.cn>
>
> Fix the following coccicheck REVIEW:
> ./drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c:1688:16-17 use swap() to make code cleaner
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: chiminghao <chi.minghao@zte.com.cn>
> ---
> drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] crypto:otx2_cptvf_algs: use swap() to make code cleaner
@ 2021-11-09 8:20 cgel.zte
0 siblings, 0 replies; 3+ messages in thread
From: cgel.zte @ 2021-11-09 8:20 UTC (permalink / raw)
To: info
Cc: vireshk, linus.walleij, brgl, linux-gpio, virtualization,
linux-kernel, chiminghao, Zeal Robot
From: chiminghao <chi.minghao@zte.com.cn>
Fix the following coccicheck REVIEW:
./drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c:1688:16-17 use swap() to make code cleaner
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: chiminghao <chi.minghao@zte.com.cn>
---
drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c b/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
index 877a948469bd..2748a3327e39 100644
--- a/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
+++ b/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
@@ -1682,11 +1682,8 @@ static void swap_func(void *lptr, void *rptr, int size)
{
struct cpt_device_desc *ldesc = lptr;
struct cpt_device_desc *rdesc = rptr;
- struct cpt_device_desc desc;
- desc = *ldesc;
- *ldesc = *rdesc;
- *rdesc = desc;
+ swap(*ldesc, *rdesc);
}
int otx2_cpt_crypto_init(struct pci_dev *pdev, struct module *mod,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-20 4:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 8:35 [PATCH] crypto:otx2_cptvf_algs: use swap() to make code cleaner cgel.zte
2021-11-20 4:31 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2021-11-09 8:20 cgel.zte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).