From: Guenter Roeck <linux@roeck-us.net>
To: David Mosberger-Tang <davidm@egauge.net>
Cc: Navin Sankar Velliangiri <navin@linumiz.com>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (sht4x) Add device tree match table and document it
Date: Sat, 20 Nov 2021 13:51:48 -0800 [thread overview]
Message-ID: <20211120215148.GA1291159@roeck-us.net> (raw)
In-Reply-To: <5f5798b3f021c419e94714ba557be0e3a40c671e.camel@egauge.net>
On Sat, Nov 20, 2021 at 02:36:39PM -0700, David Mosberger-Tang wrote:
> On Sat, 2021-11-20 at 13:12 -0800, Guenter Roeck wrote:
> > On 11/20/21 12:40 PM, David Mosberger-Tang wrote:
> > > This patch enables automatic loading of the sht4x module via a device
> > > tree table entry.
> > >
> > > Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
> > > ---
> > > .../bindings/hwmon/sensirion,sht4x.yaml | 50 +++++++++++++++++++
> > > drivers/hwmon/sht4x.c | 7 +++
> >
> > This needs to be two separate patches, one the devicetree change and the other
> > the source code change. DT maintainers need to be copied on the devicetree
> > patch.
>
> Isn't that going to be confusing if one but not the other patch makes
> it into a repository? Either you end up with an undocumented device
> tree property or you end up with documentation for an unsupported
> property.
>
This is a trivial device, so that isn't really an issue. Otherwise,
if there are real bindings to approve, I would not accept the patch
making the code change unless the devicetree patch is approved,
and I would typically apply both together.
Anyway, those are the rules. Devicetree patches need to be sent
separately and approved by a devicetree maintainer. We should not
[have to] discuss rules here. If you are unhappy with it, I would
suggest to start a discussion on the devicetree mailing list and
suggest alternatives.
Thanks,
Guenter
next prev parent reply other threads:[~2021-11-20 21:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 20:40 [PATCH v2 1/2] hwmon: (sht4x) Fix EREMOTEIO errors David Mosberger-Tang
2021-11-20 20:40 ` [PATCH v2 2/2] hwmon: (sht4x) Add device tree match table and document it David Mosberger-Tang
2021-11-20 21:12 ` Guenter Roeck
2021-11-20 21:36 ` David Mosberger-Tang
2021-11-20 21:51 ` Guenter Roeck [this message]
2021-11-21 16:15 ` David Mosberger-Tang
2021-11-20 21:08 ` [PATCH v2 1/2] hwmon: (sht4x) Fix EREMOTEIO errors Guenter Roeck
2021-11-20 21:28 ` [PATCH v3] " David Mosberger-Tang
2021-11-20 21:28 ` David Mosberger-Tang
2021-11-20 22:45 ` Guenter Roeck
2021-11-20 21:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211120215148.GA1291159@roeck-us.net \
--to=linux@roeck-us.net \
--cc=davidm@egauge.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navin@linumiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).