From: Dan Carpenter <dan.carpenter@oracle.com>
To: Zoeb Mithaiwala <zoebm@google.com>
Cc: greg@kroah.com, trivial@kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/2] Staging: rtl8712: rtl871x_security: fixed a camel case variable name coding style issue
Date: Mon, 22 Nov 2021 13:39:31 +0300 [thread overview]
Message-ID: <20211122103931.GA6514@kadam> (raw)
In-Reply-To: <20211120111151.1086970-1-zoebm@google.com>
On Sat, Nov 20, 2021 at 11:11:51AM +0000, Zoeb Mithaiwala wrote:
> Changed additional 'n' from variable name. Corrected comment indentation.
>
This is not how you're supposed to send a v2 patch.
https://kernelnewbies.org/FirstKernelPatch See the section on "Revising
your patches".
> @@ -200,11 +200,11 @@ void seccalctkipmic(
> u8 *header,
> u8 *data,
> u32 data_len,
> - u8 *miccode,
> + u8 *Miccode,
> u8 priority);
>
Take a look at the naming in the .c file where the function is
implemented and use the same name in the .h file where it's declared.
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-22 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 8:06 [PATCH] Staging: rtl8712: rtl871x_security: fixed a camel case variable name coding style issue Zoeb Mithaiwala
2021-11-20 8:26 ` Greg KH
2021-11-20 11:11 ` [PATCH 2/2] " Zoeb Mithaiwala
2021-11-22 10:39 ` Dan Carpenter [this message]
2021-11-22 17:03 ` [PATCH v3 3/3] Staging: rtl8712: Fixes a camel case variable name " Zoeb Mithaiwala
2021-11-24 10:01 ` Greg KH
2021-11-25 17:07 ` Zoeb Mithaiwala
2021-11-25 17:14 ` Greg KH
2021-11-24 10:00 ` [PATCH 2/2] Staging: rtl8712: rtl871x_security: fixed a camel case variable name coding " Greg KH
2021-11-22 15:22 ` [PATCH] " kernel test robot
2021-11-26 8:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122103931.GA6514@kadam \
--to=dan.carpenter@oracle.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=trivial@kernel.org \
--cc=zoebm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).