From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3961C433FE for ; Wed, 24 Nov 2021 12:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243554AbhKXMUv (ORCPT ); Wed, 24 Nov 2021 07:20:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:47684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242718AbhKXMP3 (ORCPT ); Wed, 24 Nov 2021 07:15:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 779DF61053; Wed, 24 Nov 2021 12:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637755814; bh=Xvip36oCyCXhVCDD2f1axnCfsa43jG9xmFBr55XnKVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CwDSw+ftdegZ2L+XeLnKanBP23dkEHMFJR5xf/Il9+UrfE9wFOhFteYjgxhWnL5aT sCkNxb04h/tzm8QltKvTkd8HOUSeVqaXJK5CfTE5+X8/1DRSogaQBYkx6xH6RsVzaU JroATx5PhEeAM166tpn8IgqoElEfe4E5+SG0tVFE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com, Rajat Asthana , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.9 068/207] media: mceusb: return without resubmitting URB in case of -EPROTO error. Date: Wed, 24 Nov 2021 12:55:39 +0100 Message-Id: <20211124115706.125654219@linuxfoundation.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124115703.941380739@linuxfoundation.org> References: <20211124115703.941380739@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rajat Asthana [ Upstream commit 476db72e521983ecb847e4013b263072bb1110fc ] Syzkaller reported a warning called "rcu detected stall in dummy_timer". The error seems to be an error in mceusb_dev_recv(). In the case of -EPROTO error, the routine immediately resubmits the URB. Instead it should return without resubmitting URB. Reported-by: syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com Signed-off-by: Rajat Asthana Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/mceusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index d9f88a4a96bd1..b78d70685b1c3 100644 --- a/drivers/media/rc/mceusb.c +++ b/drivers/media/rc/mceusb.c @@ -1090,6 +1090,7 @@ static void mceusb_dev_recv(struct urb *urb) case -ECONNRESET: case -ENOENT: case -EILSEQ: + case -EPROTO: case -ESHUTDOWN: usb_unlink_urb(urb); return; -- 2.33.0