From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D87C8C433EF for ; Wed, 24 Nov 2021 12:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344898AbhKXMi5 (ORCPT ); Wed, 24 Nov 2021 07:38:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:53336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344355AbhKXMdi (ORCPT ); Wed, 24 Nov 2021 07:33:38 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B0A39611CA; Wed, 24 Nov 2021 12:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637756445; bh=T8kPapjxySRQi2XEtlStghEYlsOPqjHtXX/wn4lH+R0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sxoHh8KELD6Pet2dyefpIkoC21mwD2pjd0KbVpwlWMyIwaU9FUfEHFp1fS8R5Aaf5 SXcFW/s4cXPhGoG5a+3h9UweP8Cqr5WJ0ITki+9QTPR6d4oBswjdhfoNG7w7sMCoQT veW+mqUCYDaxfOsnGPSICkvzqtelxYSIrlNzMmb8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Andr=C3=A9=20Almeida?= , Hans de Goede , Sebastian Reichel , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 4.14 089/251] ACPI: battery: Accept charges over the design capacity as full Date: Wed, 24 Nov 2021 12:55:31 +0100 Message-Id: <20211124115713.342917452@linuxfoundation.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124115710.214900256@linuxfoundation.org> References: <20211124115710.214900256@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: André Almeida [ Upstream commit 2835f327bd1240508db2c89fe94a056faa53c49a ] Some buggy firmware and/or brand new batteries can support a charge that's slightly over the reported design capacity. In such cases, the kernel will report to userspace that the charging state of the battery is "Unknown", when in reality the battery charge is "Full", at least from the design capacity point of view. Make the fallback condition accepts capacities over the designed capacity so userspace knows that is full. Signed-off-by: André Almeida Reviewed-by: Hans de Goede Reviewed-by: Sebastian Reichel Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 13e7b56e33aeb..30996effc491b 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -193,7 +193,7 @@ static int acpi_battery_is_charged(struct acpi_battery *battery) return 1; /* fallback to using design values for broken batteries */ - if (battery->design_capacity == battery->capacity_now) + if (battery->design_capacity <= battery->capacity_now) return 1; /* we don't do any sort of metric based on percentages */ -- 2.33.0