From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B464C433F5 for ; Wed, 24 Nov 2021 12:46:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344352AbhKXMt4 (ORCPT ); Wed, 24 Nov 2021 07:49:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:51740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245010AbhKXMqP (ORCPT ); Wed, 24 Nov 2021 07:46:15 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D8836113D; Wed, 24 Nov 2021 12:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637756830; bh=JJmoJOyaDAfT0VXiVpYvwzw3OAa0IstyolIBi50uPPw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C6Wm9ZRpAsnNXH7ThLN2l91b9+UoRYNfZw+zWMv1iqO5FiaWjAyZjYcd8FLemzKvf 6DwvXSM0Y3yq0zqoj8K0JGuFYGlfybLkFOTT14B/QSdwxBIdAWMyuQ4WZNA1SQ9l6r Gp6ngaSdizfiDPOEsu+/242eYsiQUiNlv1fRu9OU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Surabhi Boob , Tony Brelinski , Tony Nguyen , Sasha Levin Subject: [PATCH 4.14 222/251] iavf: Fix for the false positive ASQ/ARQ errors while issuing VF reset Date: Wed, 24 Nov 2021 12:57:44 +0100 Message-Id: <20211124115717.995595001@linuxfoundation.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124115710.214900256@linuxfoundation.org> References: <20211124115710.214900256@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Surabhi Boob [ Upstream commit 321421b57a12e933f92b228e0e6d0b2c6541f41d ] While issuing VF Reset from the guest OS, the VF driver prints logs about critical / Overflow error detection. This is not an actual error since the VF_MBX_ARQLEN register is set to all FF's for a short period of time and the VF would catch the bits set if it was reading the register during that spike of time. This patch introduces an additional check to ignore this condition since the VF is in reset. Fixes: 19b73d8efaa4 ("i40evf: Add additional check for reset") Signed-off-by: Surabhi Boob Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c index ad2dd5b747b23..6bc772401cff2 100644 --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c @@ -2027,7 +2027,7 @@ static void i40evf_adminq_task(struct work_struct *work) /* check for error indications */ val = rd32(hw, hw->aq.arq.len); - if (val == 0xdeadbeef) /* indicates device in reset */ + if (val == 0xdeadbeef || val == 0xffffffff) /* device in reset */ goto freedom; oldval = val; if (val & I40E_VF_ARQLEN1_ARQVFE_MASK) { -- 2.33.0