From: Rongwei Wang <rongwei.wang@linux.alibaba.com>
To: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
james.morse@arm.com, ardb@kernel.org, tabba@google.com,
akpm@linux-foundation.org, rppt@kernel.org,
anshuman.khandual@arm.com, pasha.tatashin@soleen.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/2] arm64: trans_pgd: unify the use of pmd_populate_kernel
Date: Fri, 26 Nov 2021 01:05:59 +0800 [thread overview]
Message-ID: <20211125170600.1608-2-rongwei.wang@linux.alibaba.com> (raw)
In-Reply-To: <20211125170600.1608-1-rongwei.wang@linux.alibaba.com>
In commit 5de59884ac0e ("arm64: trans_pgd: pass NULL instead
of init_mm to *_populate functions"), simply replace init_mm
with NULL for pmd_populate_kernel. But in commit 59511cfd08f3
("arm64: mm: use XN table mapping attributes for user/kernel
mappings"), adding the check of mm context in
'pmd_populate_kernel'. And 'pmd_populate_kernel' always
called with init_mm under arm64, nice to unify its use.
This patch make a simple change, just restoring init_mm for
'pmd_populate_kernel' in 'copy_pte'.
Suggested-by: Abaci <abaci@linux.alibaba.com>
Signed-off-by: Rongwei Wang <rongwei.wang@linux.alibaba.com>
---
arch/arm64/mm/trans_pgd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/mm/trans_pgd.c b/arch/arm64/mm/trans_pgd.c
index d7da8ca..5275ca3 100644
--- a/arch/arm64/mm/trans_pgd.c
+++ b/arch/arm64/mm/trans_pgd.c
@@ -67,7 +67,7 @@ static int copy_pte(struct trans_pgd_info *info, pmd_t *dst_pmdp,
dst_ptep = trans_alloc(info);
if (!dst_ptep)
return -ENOMEM;
- pmd_populate_kernel(NULL, dst_pmdp, dst_ptep);
+ pmd_populate_kernel(&init_mm, dst_pmdp, dst_ptep);
dst_ptep = pte_offset_kernel(dst_pmdp, start);
src_ptep = pte_offset_kernel(src_pmdp, start);
--
1.8.3.1
next prev parent reply other threads:[~2021-11-25 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 18:31 [PATCH 0/2] fix bug when calling kexec_load() Rongwei Wang
2021-10-30 18:31 ` [PATCH 1/2] arm64: trans_pgd: fix incorrect use of pmd_populate_kernel in copy_pte() Rongwei Wang
2021-10-31 12:25 ` Ard Biesheuvel
2021-11-01 2:14 ` Rongwei Wang
2021-11-05 5:58 ` Rongwei Wang
2021-10-30 18:32 ` [PATCH 2/2] arm64: kexec: reduce calls to page_address() Rongwei Wang
2021-11-14 20:16 ` [PATCH v2 0/2] fix bug when calling kexec_load() Rongwei Wang
2021-11-14 20:16 ` [PATCH v2 1/2] arm64: trans_pgd: fix incorrect use of pmd_populate_kernel in copy_pte() Rongwei Wang
2021-11-19 3:04 ` Rongwei Wang
2021-11-14 20:16 ` [PATCH v2 2/2] arm64: kexec: reduce calls to page_address() Rongwei Wang
2021-11-25 17:05 ` [PATCH v3 0/2] simple optimizations for page_address and Rongwei Wang
2021-11-25 17:05 ` Rongwei Wang [this message]
2021-11-25 17:06 ` [PATCH v3 2/2] arm64: kexec: reduce calls to page_address() Rongwei Wang
2021-12-10 18:40 ` (subset) [PATCH v3 0/2] simple optimizations for page_address and Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211125170600.1608-2-rongwei.wang@linux.alibaba.com \
--to=rongwei.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).