linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair.francis@opensource.wdc.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, arnd@arndb.de, namhyung@kernel.org,
	peterz@infradead.org, alistair23@gmail.com, jolsa@redhat.com,
	dave@stgolabs.net, mingo@redhat.com, dvhart@infradead.org,
	acme@kernel.org, linux-perf-users@vger.kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	Alistair Francis <alistair.francis@wdc.com>
Subject: [PATCH v3 5/6] uapi: futex: Add a futex waitv syscall
Date: Fri, 26 Nov 2021 16:00:23 +1000	[thread overview]
Message-ID: <20211126060024.3290177-5-alistair.francis@opensource.wdc.com> (raw)
In-Reply-To: <20211126060024.3290177-1-alistair.francis@opensource.wdc.com>

From: Alistair Francis <alistair.francis@wdc.com>

This commit adds a futex waitv syscall wrapper that is exposed to
userspace.

Neither the kernel or glibc currently expose a futex wrapper, so
userspace is left performing raw syscalls. As the futex_waitv syscall
always expects a 64-bit time_t this can be tricky for 32-bit systems to
get correct.

In order to avoid userspace incorrectly passing the wrong timeouts let's
expose a public helper function that ensures the kernel is passed the
correct timeout struct.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 include/uapi/linux/futex_syscall.h | 32 +++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/futex_syscall.h b/include/uapi/linux/futex_syscall.h
index e0305c581142..98c550990833 100644
--- a/include/uapi/linux/futex_syscall.h
+++ b/include/uapi/linux/futex_syscall.h
@@ -9,12 +9,15 @@
 #ifndef _UAPI_LINUX_FUTEX_SYSCALL_H
 #define _UAPI_LINUX_FUTEX_SYSCALL_H
 
-#include <asm/unistd.h>
+#include <unistd.h>
 #include <errno.h>
+#include <linux/futex.h>
 #include <linux/types.h>
 #include <linux/time_types.h>
 #include <stdint.h>
 #include <sys/syscall.h>
+#include <sys/types.h>
+#include <time.h>
 
 /**
  * futex_syscall_timeout() - __NR_futex/__NR_futex_time64 syscall wrapper
@@ -86,4 +89,31 @@ __kernel_futex_syscall_nr_requeue(volatile uint32_t *uaddr, int op, uint32_t val
 	return -1;
 }
 
+/**
+ * futex_waitv - Wait at multiple futexes, wake on any
+ * @waiters:    Array of waiters
+ * @nr_waiters: Length of waiters array
+ * @flags: Operation flags
+ * @timo:  Optional timeout for operation
+ */
+static inline int
+__kernel_futex_syscall_waitv(volatile struct futex_waitv *waiters, unsigned long nr_waiters,
+			      unsigned long flags, struct timespec *timo, clockid_t clockid)
+{
+	/* futex_waitv expects a 64-bit time_t */
+	if (sizeof(*timo) == sizeof(struct __kernel_timespec))
+		return syscall(__NR_futex_waitv, waiters, nr_waiters, flags, timo, clockid);
+
+	/* If the caller supplied a 32-bit time_t, convert it to 64-bit */
+	if (timo) {
+		struct __kernel_timespec ts_new;
+
+		ts_new.tv_sec = timo->tv_sec;
+		ts_new.tv_nsec = timo->tv_nsec;
+
+		return syscall(__NR_futex_waitv, waiters, nr_waiters, flags, &ts_new, clockid);
+	} else
+		return syscall(__NR_futex_waitv, waiters, nr_waiters, flags, NULL, clockid);
+}
+
 #endif /* _UAPI_LINUX_FUTEX_SYSCALL_H */
-- 
2.31.1


  parent reply	other threads:[~2021-11-26  6:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26  6:00 [PATCH v3 1/6] perf bench futex: Add support for 32-bit systems with 64-bit time_t Alistair Francis
2021-11-26  6:00 ` [PATCH v3 2/6] selftests: futex: Call the futex syscall from a function Alistair Francis
2021-11-26  6:00 ` [PATCH v3 3/6] uapi: futex: Add a futex syscall Alistair Francis
2021-11-26  7:24   ` Arnd Bergmann
2021-11-27  8:41   ` kernel test robot
2021-11-26  6:00 ` [PATCH v3 4/6] selftests: futex: Add support for 32-bit systems with 64-bit time_t Alistair Francis
2021-11-26  7:36   ` Arnd Bergmann
2021-11-26  6:00 ` Alistair Francis [this message]
2021-11-26  7:27   ` [PATCH v3 5/6] uapi: futex: Add a futex waitv syscall Arnd Bergmann
2021-11-26  6:00 ` [PATCH v3 6/6] selftests: futex: Use futex_waitv helper function Alistair Francis
2021-11-26  7:33   ` Arnd Bergmann
2021-11-26  7:19 ` [PATCH v3 1/6] perf bench futex: Add support for 32-bit systems with 64-bit time_t Arnd Bergmann
2022-02-26 11:47 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211126060024.3290177-5-alistair.francis@opensource.wdc.com \
    --to=alistair.francis@opensource.wdc.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alistair.francis@wdc.com \
    --cc=alistair23@gmail.com \
    --cc=arnd@arndb.de \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).