From: 전봉수 <bongsu.jeon@samsung.com>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"krzysztof.kozlowski@canonical.com"
<krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH] nfc: virtual_ncidev: change default device permissions
Date: Fri, 26 Nov 2021 15:11:50 +0900 [thread overview]
Message-ID: <20211126061150epcms2p2e7c41a092ce1c6162e9ca0e1cabb69bd@epcms2p2> (raw)
In-Reply-To: <20211125141457.716921-1-cascardo@canonical.com>
On 25/11/2021 15:14, Thadeu Lima de Souza Cascardo wrote:
> Device permissions is S_IALLUGO, with many unnecessary bits. Remove them
> and also remove read and write permissions from group and others.
>
> Before the change:
> crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci
>
> After the change:
> crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
> drivers/nfc/virtual_ncidev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/virtual_ncidev.c b/drivers/nfc/virtual_ncidev.c
> index 221fa3bb8705..f577449e4935 100644
--- a/drivers/nfc/virtual_ncidev.c
> +++ b/drivers/nfc/virtual_ncidev.c
> @@ -202,7 +202,7 @@ static int __init virtual_ncidev_init(void)
> miscdev.minor = MISC_DYNAMIC_MINOR;
> miscdev.name = "virtual_nci";
> miscdev.fops = &virtual_ncidev_fops;
> - miscdev.mode = S_IALLUGO;
> + miscdev.mode = 0600;
>
> return misc_register(&miscdev);
> }
> --
Reviewed-by: Bongsu Jeon <bongsu.jeon@samsung.com>
Thanks.
next prev parent reply other threads:[~2021-11-26 6:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 14:14 [PATCH] nfc: virtual_ncidev: change default device permissions Thadeu Lima de Souza Cascardo
2021-11-25 14:24 ` Krzysztof Kozlowski
[not found] ` <CGME20211125141522epcas2p21d45e3406fe76bdb17048553f8681af9@epcms2p2>
2021-11-26 6:11 ` 전봉수 [this message]
2021-11-26 19:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211126061150epcms2p2e7c41a092ce1c6162e9ca0e1cabb69bd@epcms2p2 \
--to=bongsu.jeon@samsung.com \
--cc=cascardo@canonical.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).