From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
gregory.clement@bootlin.com, "Andrew Lunn" <andrew@lunn.ch>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH net-next 4/4] net: mvneta: Add TC traffic shaping offload
Date: Fri, 26 Nov 2021 11:24:10 +0100 [thread overview]
Message-ID: <20211126112410.549a108d@bootlin.com> (raw)
In-Reply-To: <20211125095029.342b3594@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hello Jakub,
On Thu, 25 Nov 2021 09:50:29 -0800
Jakub Kicinski <kuba@kernel.org> wrote:
>On Thu, 25 Nov 2021 16:48:13 +0100 Maxime Chevallier wrote:
>> The mvneta controller is able to do some tocken-bucket per-queue traffic
>> shaping. This commit adds support for setting these using the TC mqprio
>> interface.
>>
>> The token-bucket parameters are customisable, but the current
>> implementation configures them to have a 10kbps resolution for the
>> rate limitation, since it allows to cover the whole range of max_rate
>> values from 10kbps to 5Gbps with 10kbps increments.
>>
>> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
>
>Breaks 32bit build, please make sure you use division helpers for 64b.
My bad, I'll update to use the proper helpers then (and compile-test
for 32bits this time too, sorry about that)
Thanks,
Maxime
--
Maxime Chevallier, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-11-26 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 15:48 [PATCH net-next 0/4] net: mvneta: mqprio cleanups and shaping support Maxime Chevallier
2021-11-25 15:48 ` [PATCH net-next 1/4] net: mvneta: Use struct tc_mqprio_qopt_offload for MQPrio configuration Maxime Chevallier
2021-11-25 15:48 ` [PATCH net-next 2/4] net: mvneta: Don't force-set the offloading flag Maxime Chevallier
2021-11-25 15:48 ` [PATCH net-next 3/4] net: mvneta: Allow having more than one queue per TC Maxime Chevallier
2021-11-25 15:48 ` [PATCH net-next 4/4] net: mvneta: Add TC traffic shaping offload Maxime Chevallier
2021-11-25 17:50 ` Jakub Kicinski
2021-11-26 10:24 ` Maxime Chevallier [this message]
2021-11-26 9:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211126112410.549a108d@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).