Re: [PATCH v2 1/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator

From: kernel test robot <lkp@intel.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator
Date: Sat, 27 Nov 2021 05:36:23 +0800	[thread overview]
Message-ID: <202111270521.Fwtu770n-lkp@intel.com> (raw)
In-Reply-To: <20211124084620.628-2-caihuoqing@baidu.com>

Hi Cai,

I love your patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Cai-Huoqing/staging-zynpu-Add-driver-support-for-ARM-China-ZHOUYI-AI-accelerator/20211124-164741
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 1189d2fb15a4b09b2e8dd01d60a0817d985d933d
config: arm64-buildonly-randconfig-r006-20211126 (https://download.01.org/0day-ci/archive/20211127/202111270521.Fwtu770n-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5162b558d8c0b542e752b037e72a69d5fd51eb1e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/95965c589ea2e279e082e3c9aa18c2ddd8494d64
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Cai-Huoqing/staging-zynpu-Add-driver-support-for-ARM-China-ZHOUYI-AI-accelerator/20211124-164741
        git checkout 95965c589ea2e279e082e3c9aa18c2ddd8494d64
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/iio/ drivers/irqchip/ drivers/spi/ drivers/staging/zynpu/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/zynpu/zynpu_session.c:747:20: warning: no previous prototype for function 'zynpu_session_get_wait_queue' [-Wmissing-prototypes]
   wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
                      ^
   drivers/staging/zynpu/zynpu_session.c:747:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
   ^
   static 
   1 warning generated.

vim +/zynpu_session_get_wait_queue +747 drivers/staging/zynpu/zynpu_session.c

   746	
 > 747	wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
   748	{
   749	    struct zynpu_thread_wait_queue *queue = NULL;
   750	
   751		if (!session) {
   752			pr_err("invalid input session to be null!");
   753			return NULL;
   754		}
   755	
   756		/* LOCK */
   757		spin_lock(&session->job_lock);
   758		queue = get_thread_wait_queue_no_lock(session->wait_queue_head, uthread_id);
   759		spin_unlock(&session->job_lock);
   760		/* UNLOCK */
   761	
   762		if (queue)
   763			return &queue->p_wait;
   764	
   765		return NULL;
   766	}
   767	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org