* [linux-stable-rc:linux-4.19.y 565/981] arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
@ 2021-11-27 2:32 kernel test robot
2021-11-27 15:10 ` Max Filippov
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2021-11-27 2:32 UTC (permalink / raw)
To: Max Filippov; +Cc: kbuild-all, linux-kernel, Greg Kroah-Hartman, Sasha Levin
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
head: 1f244a54b39dd02c69f79001b38e2650e96f1ea8
commit: 1c21a8df144f1edb3b6f5f24559825780c227a7d [565/981] xtensa: xtfpga: use CONFIG_USE_OF instead of CONFIG_OF
config: xtensa-randconfig-r001-20211126 (https://download.01.org/0day-ci/archive/20211127/202111271017.dLo8jJ8p-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=1c21a8df144f1edb3b6f5f24559825780c227a7d
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.19.y
git checkout 1c21a8df144f1edb3b6f5f24559825780c227a7d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:10,
from arch/xtensa/platforms/xtfpga/setup.c:19:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/xtensa/include/asm/page.h:182:16: warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits]
182 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
| ^~
include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/dma-mapping.h:329:9: note: in expansion of macro 'BUG_ON'
329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
| ^~~~~~
include/linux/dma-mapping.h:329:16: note: in expansion of macro 'pfn_valid'
329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
| ^~~~~~~~~
In file included from arch/xtensa/platforms/xtfpga/setup.c:37:
arch/xtensa/platforms/xtfpga/setup.c: At top level:
>> arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
50 | #define OETH_REGS_PADDR (XCHAL_KIO_PADDR + 0x0D030000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:168:26: note: in expansion of macro 'OETH_REGS_PADDR'
168 | .start = OETH_REGS_PADDR,
| ^~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: note: (near initialization for 'ethoc_res[0].start')
50 | #define OETH_REGS_PADDR (XCHAL_KIO_PADDR + 0x0D030000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:168:26: note: in expansion of macro 'OETH_REGS_PADDR'
168 | .start = OETH_REGS_PADDR,
| ^~~~~~~~~~~~~~~
>> arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
50 | #define OETH_REGS_PADDR (XCHAL_KIO_PADDR + 0x0D030000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:169:26: note: in expansion of macro 'OETH_REGS_PADDR'
169 | .end = OETH_REGS_PADDR + OETH_REGS_SIZE - 1,
| ^~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: note: (near initialization for 'ethoc_res[0].end')
50 | #define OETH_REGS_PADDR (XCHAL_KIO_PADDR + 0x0D030000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:169:26: note: in expansion of macro 'OETH_REGS_PADDR'
169 | .end = OETH_REGS_PADDR + OETH_REGS_SIZE - 1,
| ^~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:52:33: error: initializer element is not constant
52 | #define OETH_SRAMBUFF_PADDR (XCHAL_KIO_PADDR + 0x0D800000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:173:26: note: in expansion of macro 'OETH_SRAMBUFF_PADDR'
173 | .start = OETH_SRAMBUFF_PADDR,
| ^~~~~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:52:33: note: (near initialization for 'ethoc_res[1].start')
52 | #define OETH_SRAMBUFF_PADDR (XCHAL_KIO_PADDR + 0x0D800000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:173:26: note: in expansion of macro 'OETH_SRAMBUFF_PADDR'
173 | .start = OETH_SRAMBUFF_PADDR,
| ^~~~~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:52:33: error: initializer element is not constant
52 | #define OETH_SRAMBUFF_PADDR (XCHAL_KIO_PADDR + 0x0D800000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:174:26: note: in expansion of macro 'OETH_SRAMBUFF_PADDR'
174 | .end = OETH_SRAMBUFF_PADDR + OETH_SRAMBUFF_SIZE - 1,
| ^~~~~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:52:33: note: (near initialization for 'ethoc_res[1].end')
52 | #define OETH_SRAMBUFF_PADDR (XCHAL_KIO_PADDR + 0x0D800000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:174:26: note: in expansion of macro 'OETH_SRAMBUFF_PADDR'
174 | .end = OETH_SRAMBUFF_PADDR + OETH_SRAMBUFF_SIZE - 1,
| ^~~~~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:57:33: error: initializer element is not constant
57 | #define C67X00_PADDR (XCHAL_KIO_PADDR + 0x0D0D0000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:211:26: note: in expansion of macro 'C67X00_PADDR'
211 | .start = C67X00_PADDR,
| ^~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:57:33: note: (near initialization for 'c67x00_res[0].start')
57 | #define C67X00_PADDR (XCHAL_KIO_PADDR + 0x0D0D0000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:211:26: note: in expansion of macro 'C67X00_PADDR'
211 | .start = C67X00_PADDR,
| ^~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:57:33: error: initializer element is not constant
57 | #define C67X00_PADDR (XCHAL_KIO_PADDR + 0x0D0D0000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:212:26: note: in expansion of macro 'C67X00_PADDR'
212 | .end = C67X00_PADDR + C67X00_SIZE - 1,
| ^~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:57:33: note: (near initialization for 'c67x00_res[0].end')
57 | #define C67X00_PADDR (XCHAL_KIO_PADDR + 0x0D0D0000)
| ^
arch/xtensa/platforms/xtfpga/setup.c:212:26: note: in expansion of macro 'C67X00_PADDR'
212 | .end = C67X00_PADDR + C67X00_SIZE - 1,
| ^~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:37:33: error: initializer element is not constant
37 | #define DUART16552_PADDR (XCHAL_KIO_PADDR + 0x0D050020)
| ^
arch/xtensa/platforms/xtfpga/setup.c:242:19: note: in expansion of macro 'DUART16552_PADDR'
242 | .start = DUART16552_PADDR,
| ^~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:37:33: note: (near initialization for 'serial_resource.start')
37 | #define DUART16552_PADDR (XCHAL_KIO_PADDR + 0x0D050020)
| ^
arch/xtensa/platforms/xtfpga/setup.c:242:19: note: in expansion of macro 'DUART16552_PADDR'
242 | .start = DUART16552_PADDR,
| ^~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:37:33: error: initializer element is not constant
37 | #define DUART16552_PADDR (XCHAL_KIO_PADDR + 0x0D050020)
| ^
arch/xtensa/platforms/xtfpga/setup.c:243:19: note: in expansion of macro 'DUART16552_PADDR'
243 | .end = DUART16552_PADDR + 0x1f,
| ^~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:37:33: note: (near initialization for 'serial_resource.end')
37 | #define DUART16552_PADDR (XCHAL_KIO_PADDR + 0x0D050020)
| ^
arch/xtensa/platforms/xtfpga/setup.c:243:19: note: in expansion of macro 'DUART16552_PADDR'
243 | .end = DUART16552_PADDR + 0x1f,
| ^~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:37:33: error: initializer element is not constant
37 | #define DUART16552_PADDR (XCHAL_KIO_PADDR + 0x0D050020)
| ^
arch/xtensa/platforms/xtfpga/setup.c:249:35: note: in expansion of macro 'DUART16552_PADDR'
249 | .mapbase = DUART16552_PADDR,
| ^~~~~~~~~~~~~~~~
arch/xtensa/platforms/xtfpga/include/platform/hardware.h:37:33: note: (near initialization for 'serial_platform_data[0].mapbase')
37 | #define DUART16552_PADDR (XCHAL_KIO_PADDR + 0x0D050020)
| ^
arch/xtensa/platforms/xtfpga/setup.c:249:35: note: in expansion of macro 'DUART16552_PADDR'
249 | .mapbase = DUART16552_PADDR,
| ^~~~~~~~~~~~~~~~
vim +50 arch/xtensa/platforms/xtfpga/include/platform/hardware.h
0d456bad36d42d1 Max Filippov 2012-11-05 47
0d456bad36d42d1 Max Filippov 2012-11-05 48 /* OpenCores Ethernet controller: */
0d456bad36d42d1 Max Filippov 2012-11-05 49 /* regs + RX/TX descriptors */
0d456bad36d42d1 Max Filippov 2012-11-05 @50 #define OETH_REGS_PADDR (XCHAL_KIO_PADDR + 0x0D030000)
0d456bad36d42d1 Max Filippov 2012-11-05 51 #define OETH_REGS_SIZE 0x1000
0d456bad36d42d1 Max Filippov 2012-11-05 52 #define OETH_SRAMBUFF_PADDR (XCHAL_KIO_PADDR + 0x0D800000)
0d456bad36d42d1 Max Filippov 2012-11-05 53
0d456bad36d42d1 Max Filippov 2012-11-05 54 /* 5*rx buffs + 5*tx buffs */
0d456bad36d42d1 Max Filippov 2012-11-05 55 #define OETH_SRAMBUFF_SIZE (5 * 0x600 + 5 * 0x600)
0d456bad36d42d1 Max Filippov 2012-11-05 56
:::::: The code at line 50 was first introduced by commit
:::::: 0d456bad36d42d16022be045c8a53ddbb59ee478 xtensa: add support for the XTFPGA boards
:::::: TO: Max Filippov <jcmvbkbc@gmail.com>
:::::: CC: Chris Zankel <chris@zankel.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-stable-rc:linux-4.19.y 565/981] arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
2021-11-27 2:32 [linux-stable-rc:linux-4.19.y 565/981] arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant kernel test robot
@ 2021-11-27 15:10 ` Max Filippov
2021-11-28 13:03 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Max Filippov @ 2021-11-27 15:10 UTC (permalink / raw)
To: kernel test robot; +Cc: kbuild-all, LKML, Greg Kroah-Hartman, Sasha Levin
On Fri, Nov 26, 2021 at 6:33 PM kernel test robot <lkp@intel.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> head: 1f244a54b39dd02c69f79001b38e2650e96f1ea8
> commit: 1c21a8df144f1edb3b6f5f24559825780c227a7d [565/981] xtensa: xtfpga: use CONFIG_USE_OF instead of CONFIG_OF
> config: xtensa-randconfig-r001-20211126 (https://download.01.org/0day-ci/archive/20211127/202111271017.dLo8jJ8p-lkp@intel.com/config)
> compiler: xtensa-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=1c21a8df144f1edb3b6f5f24559825780c227a7d
> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> git fetch --no-tags linux-stable-rc linux-4.19.y
> git checkout 1c21a8df144f1edb3b6f5f24559825780c227a7d
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/kernel.h:10,
> from arch/xtensa/platforms/xtfpga/setup.c:19:
> include/linux/dma-mapping.h: In function 'dma_map_resource':
> arch/xtensa/include/asm/page.h:182:16: warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits]
> 182 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
> | ^~
> include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
> 77 | # define unlikely(x) __builtin_expect(!!(x), 0)
> | ^
> include/linux/dma-mapping.h:329:9: note: in expansion of macro 'BUG_ON'
> 329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
> | ^~~~~~
> include/linux/dma-mapping.h:329:16: note: in expansion of macro 'pfn_valid'
> 329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
> | ^~~~~~~~~
> In file included from arch/xtensa/platforms/xtfpga/setup.c:37:
> arch/xtensa/platforms/xtfpga/setup.c: At top level:
> >> arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
> 50 | #define OETH_REGS_PADDR (XCHAL_KIO_PADDR + 0x0D030000)
> | ^
This happens because the backported change
1c21a8df144f1edb3b6f5f24559825780c227a7d depends on the change
d67ed2510d28 ("xtensa: use CONFIG_USE_OF instead of CONFIG_OF")
which is not in that stable tree.
Should I send the backported version of the d67ed2510d28 or should
the change 1c21a8df144f1edb3b6f5f24559825780c227a7d be reverted
from the stable? (IMO they are not the stable material).
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-stable-rc:linux-4.19.y 565/981] arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
2021-11-27 15:10 ` Max Filippov
@ 2021-11-28 13:03 ` Greg Kroah-Hartman
2021-11-29 13:00 ` Max Filippov
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-11-28 13:03 UTC (permalink / raw)
To: Max Filippov; +Cc: kernel test robot, kbuild-all, LKML, Sasha Levin
On Sat, Nov 27, 2021 at 07:10:56AM -0800, Max Filippov wrote:
> On Fri, Nov 26, 2021 at 6:33 PM kernel test robot <lkp@intel.com> wrote:
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > head: 1f244a54b39dd02c69f79001b38e2650e96f1ea8
> > commit: 1c21a8df144f1edb3b6f5f24559825780c227a7d [565/981] xtensa: xtfpga: use CONFIG_USE_OF instead of CONFIG_OF
> > config: xtensa-randconfig-r001-20211126 (https://download.01.org/0day-ci/archive/20211127/202111271017.dLo8jJ8p-lkp@intel.com/config)
> > compiler: xtensa-linux-gcc (GCC) 11.2.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=1c21a8df144f1edb3b6f5f24559825780c227a7d
> > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > git fetch --no-tags linux-stable-rc linux-4.19.y
> > git checkout 1c21a8df144f1edb3b6f5f24559825780c227a7d
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from include/linux/kernel.h:10,
> > from arch/xtensa/platforms/xtfpga/setup.c:19:
> > include/linux/dma-mapping.h: In function 'dma_map_resource':
> > arch/xtensa/include/asm/page.h:182:16: warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits]
> > 182 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
> > | ^~
> > include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
> > 77 | # define unlikely(x) __builtin_expect(!!(x), 0)
> > | ^
> > include/linux/dma-mapping.h:329:9: note: in expansion of macro 'BUG_ON'
> > 329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
> > | ^~~~~~
> > include/linux/dma-mapping.h:329:16: note: in expansion of macro 'pfn_valid'
> > 329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
> > | ^~~~~~~~~
> > In file included from arch/xtensa/platforms/xtfpga/setup.c:37:
> > arch/xtensa/platforms/xtfpga/setup.c: At top level:
> > >> arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
> > 50 | #define OETH_REGS_PADDR (XCHAL_KIO_PADDR + 0x0D030000)
> > | ^
>
> This happens because the backported change
> 1c21a8df144f1edb3b6f5f24559825780c227a7d depends on the change
> d67ed2510d28 ("xtensa: use CONFIG_USE_OF instead of CONFIG_OF")
> which is not in that stable tree.
>
> Should I send the backported version of the d67ed2510d28 or should
> the change 1c21a8df144f1edb3b6f5f24559825780c227a7d be reverted
> from the stable? (IMO they are not the stable material).
I have queued up d67ed2510d28 ("xtensa: use CONFIG_USE_OF instead of
CONFIG_OF") to hopefully resolve this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-stable-rc:linux-4.19.y 565/981] arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
2021-11-28 13:03 ` Greg Kroah-Hartman
@ 2021-11-29 13:00 ` Max Filippov
2021-11-29 13:14 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Max Filippov @ 2021-11-29 13:00 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: kernel test robot, kbuild-all, LKML, Sasha Levin
Hi Greg,
On Sun, Nov 28, 2021 at 5:03 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Sat, Nov 27, 2021 at 07:10:56AM -0800, Max Filippov wrote:
> > This happens because the backported change
> > 1c21a8df144f1edb3b6f5f24559825780c227a7d depends on the change
> > d67ed2510d28 ("xtensa: use CONFIG_USE_OF instead of CONFIG_OF")
> > which is not in that stable tree.
> >
> > Should I send the backported version of the d67ed2510d28 or should
> > the change 1c21a8df144f1edb3b6f5f24559825780c227a7d be reverted
> > from the stable? (IMO they are not the stable material).
>
> I have queued up d67ed2510d28 ("xtensa: use CONFIG_USE_OF instead of
> CONFIG_OF") to hopefully resolve this.
Thank you. However the change that you've queued is missing one
hunk of the original patch that makes the difference in this case.
I guess it's missing due to conflict introduced by the change
6591685d5004 ("xtensa: move XCHAL_KIO_* definitions to kmem_layout.h")
I've posted another backported version of this patch that includes
that missing part. Could you please apply it instead?
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-stable-rc:linux-4.19.y 565/981] arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
2021-11-29 13:00 ` Max Filippov
@ 2021-11-29 13:14 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-11-29 13:14 UTC (permalink / raw)
To: Max Filippov; +Cc: kernel test robot, kbuild-all, LKML, Sasha Levin
On Mon, Nov 29, 2021 at 05:00:55AM -0800, Max Filippov wrote:
> Hi Greg,
>
> On Sun, Nov 28, 2021 at 5:03 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Sat, Nov 27, 2021 at 07:10:56AM -0800, Max Filippov wrote:
> > > This happens because the backported change
> > > 1c21a8df144f1edb3b6f5f24559825780c227a7d depends on the change
> > > d67ed2510d28 ("xtensa: use CONFIG_USE_OF instead of CONFIG_OF")
> > > which is not in that stable tree.
> > >
> > > Should I send the backported version of the d67ed2510d28 or should
> > > the change 1c21a8df144f1edb3b6f5f24559825780c227a7d be reverted
> > > from the stable? (IMO they are not the stable material).
> >
> > I have queued up d67ed2510d28 ("xtensa: use CONFIG_USE_OF instead of
> > CONFIG_OF") to hopefully resolve this.
>
> Thank you. However the change that you've queued is missing one
> hunk of the original patch that makes the difference in this case.
> I guess it's missing due to conflict introduced by the change
> 6591685d5004 ("xtensa: move XCHAL_KIO_* definitions to kmem_layout.h")
>
> I've posted another backported version of this patch that includes
> that missing part. Could you please apply it instead?
Now updated, thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-29 14:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-27 2:32 [linux-stable-rc:linux-4.19.y 565/981] arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant kernel test robot
2021-11-27 15:10 ` Max Filippov
2021-11-28 13:03 ` Greg Kroah-Hartman
2021-11-29 13:00 ` Max Filippov
2021-11-29 13:14 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).