From: Guenter Roeck <linux@roeck-us.net>
To: Anton Altaparmakov <anton@tuxera.com>
Cc: linux-ntfs-dev@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Joel Stanley <joel@jms.id.au>,
Michael Ellerman <mpe@ellerman.id.au>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v3 0/3] Limit NTFS_RW to page sizes smaller than 64k
Date: Sat, 27 Nov 2021 07:44:39 -0800 [thread overview]
Message-ID: <20211127154442.3676290-1-linux@roeck-us.net> (raw)
This is the third attempt to fix the following build error.
fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
fs/ntfs/aops.c:1311:1: error:
the frame size of 2240 bytes is larger than 2048 bytes
The problem is that NTFS_RW code allocates page size dependent arrays on
the stack. This results in build failures if the page size is 64k or
larger.
Since commit f22969a66041 ("powerpc/64s: Default to 64K pages for 64 bit
book3s") this affects ppc:allmodconfig builds, but other architectures
supporting page sizes of 64k or larger are also affected.
Increasing the maximum frame size for affected architectures just to
silence this error does not really help. The frame size would have to be
set to a really large value for 256k pages. Also, a large frame size could
potentially result in stack overruns in this code and elsewhere and is
therefore not desirable. Make NTFS_RW dependent on page sizes smaller than
64k instead.
Previous attempts to fix the problem were local to the ntfs subsystem.
This attempt introduces the architecture independent configuration flag
PAGE_SIZE_LESS_THAN_64KB and uses it to restrict NTFS_RW. The last patch
of the series replaces a similar restriction for VMXNET3 with the new
flag. This patch is not necessary to fix the NTFS_RW problem and is
provided only for completeness.
next reply other threads:[~2021-11-27 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 15:44 Guenter Roeck [this message]
2021-11-27 15:44 ` [PATCH v3 1/3] arch: Add generic Kconfig option indicating page size smaller than 64k Guenter Roeck
2021-11-27 15:44 ` [PATCH v3 2/3] fs: ntfs: Limit NTFS_RW to page sizes " Guenter Roeck
2021-11-27 15:44 ` [PATCH v3 3/3] vmxnet3: Use generic Kconfig option for page size limit Guenter Roeck
2021-11-27 17:49 ` [PATCH v3 0/3] Limit NTFS_RW to page sizes smaller than 64k Linus Torvalds
2021-11-27 22:26 ` Guenter Roeck
2021-11-27 22:31 ` Linus Torvalds
2021-11-27 22:44 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211127154442.3676290-1-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=anton@tuxera.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).