From: Dongliang Mu <mudongliangabcd@gmail.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: Dongliang Mu <mudongliangabcd@gmail.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] driver: nvme: fix missing error code
Date: Tue, 30 Nov 2021 21:50:14 +0800 [thread overview]
Message-ID: <20211130135015.1818325-1-mudongliangabcd@gmail.com> (raw)
Smatch reports:
drivers/nvme/host/multipath.c:865
nvme_mpath_init_identify() warn: missing error code 'error'
In one error handling path of nvme_mpath_init_identify(Line 865), error
is not initialized as an errno.
Fix this by assigning error to -EINVAL.
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
drivers/nvme/host/multipath.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 7f2071f2460c..2cbeb6d6b064 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -862,6 +862,7 @@ int nvme_mpath_init_identify(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id)
"ANA log page size (%zd) larger than MDTS (%zd).\n",
ana_log_size, max_transfer_size);
dev_err(ctrl->device, "disabling ANA support.\n");
+ error = -EINVAL;
goto out_uninit;
}
if (ana_log_size > ctrl->ana_log_size) {
--
2.25.1
next reply other threads:[~2021-11-30 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 13:50 Dongliang Mu [this message]
2021-11-30 15:47 ` [PATCH] driver: nvme: fix missing error code Keith Busch
2021-12-01 2:04 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130135015.1818325-1-mudongliangabcd@gmail.com \
--to=mudongliangabcd@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).