From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"David Heidelberg" <david@ixit.cz>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
"Anton Bambura" <jenneron@protonmail.com>,
"Antoni Aloy Torrens" <aaloytorrens@gmail.com>,
"Nikola Milosavljevic" <mnidza@outlook.com>,
"Ion Agorria" <ion@agorria.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Ihor Didenko" <tailormoon@rambler.ru>,
"Andreas Westman Dorcsak" <hedmoo@yahoo.com>,
"Maxim Schwalm" <maxim.schwalm@gmail.com>,
"Raffaele Tranquillini" <raffaele.tranquillini@gmail.com>,
"Jasper Korten" <jja2000@gmail.com>,
"Thomas Graichen" <thomas.graichen@gmail.com>,
"Stefan Eichenberger" <stefan.eichenberger@toradex.com>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 15/24] ARM: tegra: Add usb-role-switch property to USB OTG ports
Date: Wed, 1 Dec 2021 01:38:11 +0300 [thread overview]
Message-ID: <20211130223820.23609-16-digetx@gmail.com> (raw)
In-Reply-To: <20211130223820.23609-1-digetx@gmail.com>
From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
If an USB port is an OTG port, then we should add the usb-role-switch
property. Otherwise XUSB setup fails and therefore padctl is unable to
set up the ports. This leads to broken USB and PCIe ports. Add the
usb-role-switch properties to Tegra124 device-trees to fix the problem.
The error message shown without this patch is e.g:
usb2-0: usb-role-switch not found for otg mode
[digetx@gmail.com: improved commit message]
Tested-by: Thomas Graichen <thomas.graichen@gmail.com> # T124 Nyan Big
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 1 +
arch/arm/boot/dts/tegra124-apalis.dtsi | 1 +
arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
arch/arm/boot/dts/tegra124-venice2.dts | 2 +-
4 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
index cde9ae8fa04b..b9198f842a34 100644
--- a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
+++ b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
@@ -1885,6 +1885,7 @@ ports {
usb2-0 {
status = "okay";
mode = "otg";
+ usb-role-switch;
vbus-supply = <®_usbo1_vbus>;
};
diff --git a/arch/arm/boot/dts/tegra124-apalis.dtsi b/arch/arm/boot/dts/tegra124-apalis.dtsi
index a46d9ba9bb7a..1a996fb78ee2 100644
--- a/arch/arm/boot/dts/tegra124-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra124-apalis.dtsi
@@ -1877,6 +1877,7 @@ ports {
usb2-0 {
status = "okay";
mode = "otg";
+ usb-role-switch;
vbus-supply = <®_usbo1_vbus>;
};
diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
index 63a81270300a..93a40a84b792 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -466,6 +466,7 @@ usb2-0 {
vbus-supply = <&vdd_usb1_vbus>;
status = "okay";
mode = "otg";
+ usb-role-switch;
};
usb2-1 {
diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
index e6b54ac1ebd1..de8c18e6b7e6 100644
--- a/arch/arm/boot/dts/tegra124-venice2.dts
+++ b/arch/arm/boot/dts/tegra124-venice2.dts
@@ -972,7 +972,7 @@ ports {
usb2-0 {
status = "okay";
mode = "otg";
-
+ usb-role-switch;
vbus-supply = <&vdd_usb1_vbus>;
};
--
2.33.1
next prev parent reply other threads:[~2021-11-30 22:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 22:37 [PATCH v4 00/24] NVIDIA Tegra ARM32 device-tree patches for 5.17 (new devices and more) Dmitry Osipenko
2021-11-30 22:37 ` [PATCH v4 01/24] dt-bindings: ARM: tegra: Document ASUS Transformers Dmitry Osipenko
2021-11-30 22:37 ` [PATCH v4 02/24] dt-bindings: ARM: tegra: Document Pegatron Chagall Dmitry Osipenko
2021-11-30 22:37 ` [PATCH v4 03/24] ARM: tegra: Add labels to tegra30.dtsi Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 04/24] ARM: tegra: Add labels to tegra114.dtsi Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 05/24] ARM: tegra: Add device-tree for ASUS Transformer EeePad TF101 Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 06/24] ARM: tegra: Add common device-tree base for Tegra30 ASUS Transformers Dmitry Osipenko
2021-12-01 10:07 ` Michał Mirosław
2021-12-01 14:08 ` Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 07/24] ARM: tegra: Add common device-tree for display panel of ASUS devices Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 08/24] ARM: tegra: Add device-tree for ASUS Transformer Prime TF201 Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 09/24] ARM: tegra: Add device-tree for ASUS Transformer Pad TF300T Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 10/24] ARM: tegra: Add device-tree for ASUS Transformer Pad TF300TG Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 11/24] ARM: tegra: Add device-tree for ASUS Transformer Infinity TF700T Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 12/24] ARM: tegra: Add device-tree for ASUS Transformer Pad TF701T Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 13/24] ARM: tegra: Add device-tree for Pegatron Chagall tablet Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 14/24] ARM: tegra: Add device-tree for 1080p version of Nyan Big Dmitry Osipenko
2021-11-30 22:38 ` Dmitry Osipenko [this message]
2021-11-30 22:38 ` [PATCH v4 16/24] ARM: tegra: Enable HDMI CEC on Nyan Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 17/24] ARM: tegra: Enable CPU DFLL " Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 18/24] ARM: tegra: Add CPU thermal zones to Nyan device-tree Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 19/24] ARM: tegra: Name clock and regulator nodes according to DT-schema Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 20/24] ARM: tegra: nexus7: Drop clock-frequency from NFC node Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 21/24] ARM: tegra: nexus7: Use common LVDS display device-tree Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 22/24] ARM: tegra: Enable video decoder on Tegra114 Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 23/24] ARM: tegra_defconfig: Enable drivers wanted by Acer Chromebooks and ASUS tablets Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 24/24] ARM: config: multi v7: Enable display drivers used by Tegra devices Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130223820.23609-16-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=aaloytorrens@gmail.com \
--cc=clamor95@gmail.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=hedmoo@yahoo.com \
--cc=ion@agorria.com \
--cc=jenneron@protonmail.com \
--cc=jja2000@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maxim.schwalm@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mnidza@outlook.com \
--cc=raffaele.tranquillini@gmail.com \
--cc=stefan.eichenberger@toradex.com \
--cc=tailormoon@rambler.ru \
--cc=thierry.reding@gmail.com \
--cc=thomas.graichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).