From: Marijn Suijten <marijn.suijten@somainline.org>
To: Martin Botka <martin.botka@somainline.org>
Cc: martin.botka1@gmail.com, ~postmarketos/upstreaming@lists.sr.ht,
konrad.dybcio@somainline.org,
angelogioacchino.delregno@somainline.org,
jamipkettunen@somainline.org, paul.bouchara@somainline.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dt: qcom: sm6125.dtsi: Add dispcc
Date: Wed, 1 Dec 2021 16:51:28 +0100 [thread overview]
Message-ID: <20211201155128.sasoiv3awjcfrjhw@SoMainline.org> (raw)
In-Reply-To: <20211130212137.25303-3-martin.botka@somainline.org>
On 2021-11-30 22:21:34, Martin Botka wrote:
> Add the dispcc node from the newly added DISPCC
> driver for Qualcomm Technology Inc's SM6125 SoC.
>
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
> arch/arm64/boot/dts/qcom/sm6125.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> index 51286ddbdb10..78f4705e4117 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> @@ -3,6 +3,7 @@
> * Copyright (c) 2021, Martin Botka <martin.botka@somainline.org>
> */
>
> +#include <dt-bindings/clock/qcom,dispcc-sm6125.h>
> #include <dt-bindings/clock/qcom,gcc-sm6125.h>
> #include <dt-bindings/clock/qcom,rpmcc.h>
> #include <dt-bindings/gpio/gpio.h>
> @@ -317,6 +318,17 @@ soc {
> ranges = <0x00 0x00 0x00 0xffffffff>;
> compatible = "simple-bus";
>
> + dispcc: clock-controller@5f00000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "qcom,dispcc-sm6125";
> + reg = <0x5f00000 0x20000>;
> + clocks = <&gcc GCC_DISP_AHB_CLK>;
> + clock-names = "cfg_ahb_clk";
It looks like this lacks all the clocks that are supposedly required as
per the yaml DT bindings provided in patch 1/3 - should those be added
and set to `<0>` where unavailable, otherwise dtbs_check may not pass?
> + #clock-cells = <1>;
> + #power-domain-cells = <1>;
> + };
> +
> tcsr_mutex: hwlock@340000 {
> compatible = "qcom,tcsr-mutex";
> reg = <0x00340000 0x20000>;
> --
> 2.34.0
>
next prev parent reply other threads:[~2021-12-01 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 21:21 [PATCH 1/3] dt-bindings: clock: add QCOM SM6125 display clock bindings Martin Botka
2021-11-30 21:21 ` [PATCH 2/3] clk: qcom: Add display clock controller driver for SM6125 Martin Botka
2021-12-01 15:46 ` Marijn Suijten
2021-12-01 16:07 ` AngeloGioacchino Del Regno
2021-11-30 21:21 ` [PATCH 3/3] arm64: dt: qcom: sm6125.dtsi: Add dispcc Martin Botka
2021-12-01 15:51 ` Marijn Suijten [this message]
2021-12-01 16:12 ` AngeloGioacchino Del Regno
2021-12-01 16:06 ` [PATCH 1/3] dt-bindings: clock: add QCOM SM6125 display clock bindings Marijn Suijten
2021-12-07 21:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201155128.sasoiv3awjcfrjhw@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka1@gmail.com \
--cc=martin.botka@somainline.org \
--cc=mturquette@baylibre.com \
--cc=paul.bouchara@somainline.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).